Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-22 Thread Daniel Verite
Tom Lane wrote: > If we take this patch, what's to stop someone from complaining that we > broke *their* badly-designed system that abuses the HOME variable? POSIX warns against doing that, listing HOME in the variables that should be left to their intended usage:

Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-21 Thread Peter Eisentraut
On 9/20/16 1:44 PM, Rudolf Gavlas wrote: > If you think that using the value of HOME variable as the user's home > directory is bad idea, I won't argue with that, I've already expressed > my opinion. What is the real problem here is using home directory of a > user A as a home directory for user

Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-21 Thread Aleksander Alekseev
> I work in an environment, where servers are administered by people > with different user names and identical uid (0). Multiple users with same uid is orthodox indeed. Just out of curiosity - what environment is this, if it's not a secret? > The usage of HOME environment variable (if set) is

Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-20 Thread Rudolf Gavlas
2016-09-20 18:35 GMT+02:00, Tom Lane : > Rudolf Gavlas writes: >> The usage of HOME environment variable (if set) is IMO the right, >> standard and faster way to get_home_path(). > > Can you provide some evidence for that claim? I can believe "faster"

Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-20 Thread Rudolf Gavlas
2016-09-20 18:55 GMT+02:00, Alvaro Herrera : > Rudolf Gavlas wrote: > >> I work in an environment, where servers are administered by people >> with different user names and identical uid (0). > > So everyone is superuser there? That sounds, um, unorthodox. Yes, the

Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-20 Thread Alvaro Herrera
Rudolf Gavlas wrote: > 2016-09-20 18:55 GMT+02:00, Alvaro Herrera : > > Rudolf Gavlas wrote: > > > >> I work in an environment, where servers are administered by people > >> with different user names and identical uid (0). > > > > So everyone is superuser there? That

Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-20 Thread Alvaro Herrera
Rudolf Gavlas wrote: > I work in an environment, where servers are administered by people > with different user names and identical uid (0). So everyone is superuser there? That sounds, um, unorthodox. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] [PATCH] get_home_path: use HOME

2016-09-20 Thread Tom Lane
Rudolf Gavlas writes: > The usage of HOME environment variable (if set) is IMO the right, > standard and faster way to get_home_path(). Can you provide some evidence for that claim? I can believe "faster" but the rest sounds like wishful thinking. > I work in an

[HACKERS] [PATCH] get_home_path: use HOME

2016-09-20 Thread Rudolf Gavlas
Hi, I work in an environment, where servers are administered by people with different user names and identical uid (0). The attached patch fixes a bug exposed in such environments: where the logic of retrieving a personal configuration file relies solely on get_home_path(), the different users