Re: [HACKERS] [PATCH v4] GSSAPI encryption support

2016-02-12 Thread David Steele
Hi Robbie, On 2/10/16 4:06 PM, Robbie Harwood wrote: > Hello friends, > > For your consideration, here is a new version of GSSAPI encryption > support. For those who prefer, it's also available on my github: > https://github.com/frozencemetery/postgres/commit/c92275b6605d7929cda5551de47a4c60aab7

Re: [HACKERS] [PATCH v4] GSSAPI encryption support

2016-02-11 Thread Michael Paquier
On Fri, Feb 12, 2016 at 3:56 AM, Robbie Harwood wrote: > Michael Paquier writes: >> On Thu, Feb 11, 2016 at 6:06 AM, Robbie Harwood wrote: >>> - The GSSAPI authentication code has been moved without modification. >>> In doing so, the temptation to modify it (flags, error checking, that >>> b

Re: [HACKERS] [PATCH v4] GSSAPI encryption support

2016-02-11 Thread Robbie Harwood
Michael Paquier writes: > On Thu, Feb 11, 2016 at 6:06 AM, Robbie Harwood wrote: >> >> - The GSSAPI authentication code has been moved without modification. >> In doing so, the temptation to modify it (flags, error checking, that >> big comment at the top about things from Athena, etc.) is

Re: [HACKERS] [PATCH v4] GSSAPI encryption support

2016-02-11 Thread Robert Haas
On Thu, Feb 11, 2016 at 8:42 AM, Michael Paquier wrote: > + * Portions Copyright (c) 2015-2016, Red Hat, Inc. > + * Portions Copyright (c) 1996-2016, PostgreSQL Global Development Group > I think that this part may be a problem... Not sure the feeling of the > others regarding additional copyright

Re: [HACKERS] [PATCH v4] GSSAPI encryption support

2016-02-11 Thread Michael Paquier
On Thu, Feb 11, 2016 at 6:06 AM, Robbie Harwood wrote: > For your consideration, here is a new version of GSSAPI encryption > support. For those who prefer, it's also available on my github: > https://github.com/frozencemetery/postgres/commit/c92275b6605d7929cda5551de47a4c60aab7179e Yeah! Glad t

Re: [HACKERS] [PATCH v4] GSSAPI encryption support

2016-02-10 Thread Robbie Harwood
Hello friends, For your consideration, here is a new version of GSSAPI encryption support. For those who prefer, it's also available on my github: https://github.com/frozencemetery/postgres/commit/c92275b6605d7929cda5551de47a4c60aab7179e Some thoughts: - The overall design is different this tim