Re: [HACKERS] [PATCH v8] GSSAPI encryption support

2016-03-29 Thread David Steele
On 3/29/16 5:05 PM, Robbie Harwood wrote: > David Steele writes: > >> On 3/20/16 12:09 AM, Robbie Harwood wrote: >> >>> A new version of my GSSAPI encryption patchset is available >> >> Here's a more thorough review: > > Thanks for the review! To keep this a manageable size, I'm going to > trim

Re: [HACKERS] [PATCH v8] GSSAPI encryption support

2016-03-29 Thread Robbie Harwood
David Steele writes: > On 3/20/16 12:09 AM, Robbie Harwood wrote: > >> A new version of my GSSAPI encryption patchset is available > > Here's a more thorough review: Thanks for the review! To keep this a manageable size, I'm going to trim pretty heavily. If I haven't replied to something, plea

Re: [HACKERS] [PATCH v8] GSSAPI encryption support

2016-03-29 Thread David Steele
Hi Robbie, On 3/20/16 12:09 AM, Robbie Harwood wrote: A new version of my GSSAPI encryption patchset is available Here's a more thorough review: * PATCH - Move common GSSAPI code into its own files diff --git a/src/backend/libpq/be-gssapi-common.c + if (msg_ctx) + + /*

Re: [HACKERS] [PATCH v8] GSSAPI encryption support

2016-03-25 Thread Michael Paquier
On Fri, Mar 25, 2016 at 10:10 PM, David Steele wrote: > Excellent, Robbie! I've run this patch through my test cases and > everything works. > > Now that it's working I'll be writing up an actual review so expect that > by Monday. (I haven't given up on this patch yet, sorry for the low activity

Re: [HACKERS] [PATCH v8] GSSAPI encryption support

2016-03-25 Thread David Steele
On 3/20/16 12:09 AM, Robbie Harwood wrote: > Hello friends, > > A new version of my GSSAPI encryption patchset is available, both in > this email and on my github: > https://github.com/frozencemetery/postgres/tree/feature/gssencrypt8 Excellent, Robbie! I've run this patch through my test cases a

[HACKERS] [PATCH v8] GSSAPI encryption support

2016-03-19 Thread Robbie Harwood
Hello friends, A new version of my GSSAPI encryption patchset is available, both in this email and on my github: https://github.com/frozencemetery/postgres/tree/feature/gssencrypt8 What changed: - Fixed fallback in the new server/old client case. The server flag checking has been reduced. In