Re: [HACKERS] [PATCHES] Foreign key type checking patch

2004-03-02 Thread Fabien COELHO
Hello again, I turn the discussion to the dev list as it seems more appropriate. So about the proposed patch to warn if foreign key type do not match the target key: Stephan Szabo [EMAIL PROTECTED] writes: I'm really not sure that it makes sense to warn for the fk cases where the

Re: [HACKERS] [PATCHES] Foreign key type checking patch

2004-03-02 Thread Stephan Szabo
On Tue, 2 Mar 2004, Fabien COELHO wrote: Hello again, I turn the discussion to the dev list as it seems more appropriate. So about the proposed patch to warn if foreign key type do not match the target key: Stephan Szabo [EMAIL PROTECTED] writes: I'm really not sure that it makes

Re: [HACKERS] [PATCHES] Foreign key type checking patch

2004-03-02 Thread Fabien COELHO
Hello Stephan, CREATE TABLE foo(fid INT4 NOT NULL PRIMARY KEY, ...); CREATE TABLE bla(fid INT2 REFERENCES foo, ...); The application will be fine till you enter fid=32767, and it inserts will fail in bla with fid=32768. Much later on. Which is fine if bla is meant to store a subset

Re: [HACKERS] [PATCHES] Foreign key type checking patch

2004-03-02 Thread Stephan Szabo
On Tue, 2 Mar 2004, Fabien COELHO wrote: Hello Stephan, CREATE TABLE foo(fid INT4 NOT NULL PRIMARY KEY, ...); CREATE TABLE bla(fid INT2 REFERENCES foo, ...); The application will be fine till you enter fid=32767, and it inserts will fail in bla with fid=32768. Much later on.

Re: [HACKERS] [PATCHES] Foreign key type checking patch

2004-03-02 Thread Fabien COELHO
Dear Stephan, Although it is POSSIBLE that this is fine, it is much more PROBABLE that it is a bug, hence I just suggest to issue a mere simple basic plain user-friendly little warning, what is quite different from issuing an error. [...] Why not allowing that kind of approach in