Hello,
thank you, for you review. Grouping Sets is nice feature, but this
patch patch has some issues, and I don't expect commiting into 8.4. I
sent it, because it is interaction with window function's patch and
(maybe) some code should be shared - and this information should be
usefull for other
Hi Stehule,
I have looked at the patch and it looks great. Here are my observation
Compilation
1 - Patch applied successfully on CVS-HEAD
2 - No compilation error found
Code
---
1 - Style of code is very close to the existing PG code.
2 - Comments look OK to me.
3 - I haven'