Re: [HACKERS] [Segmentation fault] pg_dump binary-upgrade fail for type without element

2014-10-17 Thread Tom Lane
Rushabh Lathia rushabh.lat...@gmail.com writes: pg_dump binary-upgrade fail with segmentation fault for type without element. Ooops. Looking further into code I found that rather then fetching typrelid, we can use the already stored typrelid from TypeInfo structure. Agreed. Patch

Re: [HACKERS] [Segmentation fault] pg_dump binary-upgrade fail for type without element

2014-10-16 Thread Amit Kapila
On Thu, Oct 16, 2014 at 11:16 AM, Rushabh Lathia rushabh.lat...@gmail.com wrote: PFA patch patch for the master branch. I think you should upload this patch to CF to avoid getting it lost. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com

[HACKERS] [Segmentation fault] pg_dump binary-upgrade fail for type without element

2014-10-15 Thread Rushabh Lathia
Hi All, pg_dump binary-upgrade fail with segmentation fault for type without element. Consider the following testcase: rushabh@postgresql$ ./db/bin/psql postgres psql (9.5devel) Type help for help. postgres=# drop type typ; DROP TYPE postgres=# create type typ as (); CREATE TYPE postgres=# \q

Re: [HACKERS] [Segmentation fault] pg_dump binary-upgrade fail for type without element

2014-10-15 Thread Rushabh Lathia
PFA patch patch for the master branch. On Thu, Oct 16, 2014 at 11:09 AM, Rushabh Lathia rushabh.lat...@gmail.com wrote: Hi All, pg_dump binary-upgrade fail with segmentation fault for type without element. Consider the following testcase: rushabh@postgresql$ ./db/bin/psql postgres psql