Re: [HACKERS] [patch] psql tab completion for grant execute

2015-08-19 Thread Daniel Verite
Robert Haas wrote: A trivial patch is attached. It adds the condition that if EXECUTE is preceded by GRANT itself preceded by nothing, then that completion with PROCEDURE is skipped. Thanks, I committed this. I don't think we usually back-patch tab completion fixes, but I

Re: [HACKERS] [patch] psql tab completion for grant execute

2015-08-18 Thread Robert Haas
On Mon, Aug 17, 2015 at 5:07 PM, Daniel Verite dan...@manitou-mail.org wrote: When tab-completing after GRANT EXECUTE, currently psql injects PROCEDURE, rather than the expected ON. The code for completing with ON is there, but it's not reached due to falling earlier into another branch, one

Re: [HACKERS] [patch] psql tab completion for grant execute

2015-08-17 Thread Michael Paquier
On Tue, Aug 18, 2015 at 6:07 AM, Daniel Verite dan...@manitou-mail.org wrote: Hi, When tab-completing after GRANT EXECUTE, currently psql injects PROCEDURE, rather than the expected ON. The code for completing with ON is there, but it's not reached due to falling earlier into another

[HACKERS] [patch] psql tab completion for grant execute

2015-08-17 Thread Daniel Verite
Hi, When tab-completing after GRANT EXECUTE, currently psql injects PROCEDURE, rather than the expected ON. The code for completing with ON is there, but it's not reached due to falling earlier into another branch, one that handles CREATE TRIGGER. A trivial patch is attached. It adds the