Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-04-07 Thread Robert Haas
On Wed, Apr 5, 2017 at 10:18 AM, Robert Haas wrote: >>> Ugh, OK. I committed this, but I think this whole file needs a visit >>> from the message style police. >> >> Like this? > > I was thinking of maybe not creating two separate (translatable) > messages, and just using

Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-04-05 Thread Robert Haas
On Wed, Apr 5, 2017 at 3:59 AM, Thomas Munro wrote: > On Thu, Mar 30, 2017 at 3:50 AM, Robert Haas wrote: >> On Wed, Mar 29, 2017 at 1:31 AM, Thomas Munro >> wrote: >>> I considered whether the error message

Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-04-05 Thread Thomas Munro
On Thu, Mar 30, 2017 at 3:50 AM, Robert Haas wrote: > On Wed, Mar 29, 2017 at 1:31 AM, Thomas Munro > wrote: >> I considered whether the error message could be improved but it >> matches the message for an existing similar case (where you try

Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-03-29 Thread Andreas Seltenreich
Thomas Munro writes: > Based on feedback on another thread about how to make reviewers' and > committers' jobs easier, here is a format-patch version with a short > description as raw material for a commit message, in case that is > helpful. +1 It's quite convenient. Otherwise I have to be

Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-03-29 Thread Robert Haas
On Wed, Mar 29, 2017 at 1:31 AM, Thomas Munro wrote: > I considered whether the error message could be improved but it > matches the message for an existing similar case (where you try to > attach to an unknown handle). Ugh, OK. I committed this, but I think this

Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-03-28 Thread Thomas Munro
On Mon, Mar 27, 2017 at 6:53 PM, Thomas Munro wrote: > On Mon, Mar 27, 2017 at 8:38 AM, Thomas Munro > wrote: >> On Mon, Mar 27, 2017 at 4:18 AM, Andreas Seltenreich >> wrote: >>> Hi, >>> >>> today's testing with

Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-03-26 Thread Thomas Munro
On Mon, Mar 27, 2017 at 8:38 AM, Thomas Munro wrote: > On Mon, Mar 27, 2017 at 4:18 AM, Andreas Seltenreich > wrote: >> Hi, >> >> today's testing with master as of d253b0f6e3 yielded two clusters that >> stopped processing queries. Symptoms:

Re: [HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-03-26 Thread Thomas Munro
On Mon, Mar 27, 2017 at 4:18 AM, Andreas Seltenreich wrote: > Hi, > > today's testing with master as of d253b0f6e3 yielded two clusters that > stopped processing queries. Symptoms: > > [...] Thanks Andreas. Investigating. -- Thomas Munro http://www.enterprisedb.com --

[HACKERS] [sqlsmith] Unpinning error in parallel worker

2017-03-26 Thread Andreas Seltenreich
Hi, today's testing with master as of d253b0f6e3 yielded two clusters that stopped processing queries. Symptoms: regression=> select application_name, state, wait_event, wait_event_type, count(1), min(pid) from pg_stat_activity group by 1,2,3,4; application_name | state |