Re: [HACKERS] A problem with dump/restore of views containing whole row references

2012-04-27 Thread Tom Lane
Abbas Butt writes: > On Fri, Apr 27, 2012 at 11:21 PM, Tom Lane wrote: >> More generally, it seems rather inelegant to be forcibly adding a cast >> when in most cases the existing notation is not wrong. AFAICS the >> plain "relname" notation is only ambiguous if there is a column of the >> same

Re: [HACKERS] A problem with dump/restore of views containing whole row references

2012-04-27 Thread Abbas Butt
On Fri, Apr 27, 2012 at 11:21 PM, Tom Lane wrote: > Andrew Dunstan writes: > > Right, what I'm asking is whether or not we actually want that side > > effect in all cases, and specifically in this case where it's clearly > > not necessary. > > We could dodge that case by only changing the behavi

Re: [HACKERS] A problem with dump/restore of views containing whole row references

2012-04-27 Thread Tom Lane
Andrew Dunstan writes: > Right, what I'm asking is whether or not we actually want that side > effect in all cases, and specifically in this case where it's clearly > not necessary. We could dodge that case by only changing the behavior when showstar is false; there is no need to change it othe

Re: [HACKERS] A problem with dump/restore of views containing whole row references

2012-04-27 Thread Andrew Dunstan
On 04/27/2012 12:02 PM, Abbas Butt wrote: However, is this a change we really want to make?: pg_get_triggerdef ---

Re: [HACKERS] A problem with dump/restore of views containing whole row references

2012-04-27 Thread Abbas Butt
On Fri, Apr 27, 2012 at 6:25 PM, Andrew Dunstan wrote: > > > On 04/27/2012 08:25 AM, Abbas Butt wrote: > >> >> The notation "relation.*" represents a whole-row reference. >> While parsing a whole-row reference is transformed into a Var with varno >> set to the correct range table entry, >> and va

Re: [HACKERS] A problem with dump/restore of views containing whole row references

2012-04-27 Thread Andrew Dunstan
On 04/27/2012 08:25 AM, Abbas Butt wrote: The notation "relation.*" represents a whole-row reference. While parsing a whole-row reference is transformed into a Var with varno set to the correct range table entry, and varattno == 0 to signal that it references the whole tuple. (For reference

[HACKERS] A problem with dump/restore of views containing whole row references

2012-04-27 Thread Abbas Butt
Hi, This is the version I used to run the following commands select version(); version PostgreSQL 9.2devel on x86_64-unknown-linux-gnu, compiled by gcc (Ubuntu/Linaro 4.4.4-14ubuntu5