Re: [HACKERS] AIX buildfarm failure

2006-07-13 Thread Bruce Momjian
; Cc: Rocco Altier; pgsql-hackers@postgresql.org > > Subject: Re: [HACKERS] AIX buildfarm failure > > > > > > > > Fixed. > > > > -- > > - > > > > Tom Lane wrote: >

Re: [HACKERS] AIX buildfarm failure

2006-07-13 Thread Rocco Altier
mailto:[EMAIL PROTECTED] > Sent: Thursday, July 13, 2006 4:14 PM > To: Tom Lane > Cc: Rocco Altier; pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] AIX buildfarm failure > > > > Fixed. > > --

Re: [HACKERS] AIX buildfarm failure

2006-07-13 Thread Bruce Momjian
Fixed. --- Tom Lane wrote: > "Rocco Altier" <[EMAIL PROTECTED]> writes: > > If I move down after "postgres.h" in nodeHash.c, the problem > > goes away. > > Bruce, you broke it. Have you forgotten the fundamental inclusion

Re: [HACKERS] AIX buildfarm failure

2006-07-13 Thread Tom Lane
"Rocco Altier" <[EMAIL PROTECTED]> writes: > If I move down after "postgres.h" in nodeHash.c, the problem > goes away. Bruce, you broke it. Have you forgotten the fundamental inclusion rule? postgres.h (or postgres_fe.h, or c.h) first, then system headers, then our own other headers.

[HACKERS] AIX buildfarm failure

2006-07-13 Thread Rocco Altier
I am seeing buildfarm failures on AIX because stdio.h is being included before pg_config.h (which has the definition of _LARGE_FILES). The problem is stemming from math.h including stdlib.h, which (after several more inclusions) ends up including stdio.h. This is where the fgetpos64 different def