[HACKERS] AIX buildfarm failure
I am seeing buildfarm failures on AIX because stdio.h is being included before pg_config.h (which has the definition of _LARGE_FILES). The problem is stemming from math.h including stdlib.h, which (after several more inclusions) ends up including stdio.h. This is where the fgetpos64 different definitions is coming from. If I move math.h down after postgres.h in nodeHash.c, the problem goes away. Do we want to consider putting math.h into the standard include set? Or is there a general rule that postgres.h needs to be the first include file (before system headers, etc)? Thanks, -rocco ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [HACKERS] AIX buildfarm failure
Rocco Altier [EMAIL PROTECTED] writes: If I move math.h down after postgres.h in nodeHash.c, the problem goes away. Bruce, you broke it. Have you forgotten the fundamental inclusion rule? postgres.h (or postgres_fe.h, or c.h) first, then system headers, then our own other headers. regards, tom lane ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [HACKERS] AIX buildfarm failure
Fixed. --- Tom Lane wrote: Rocco Altier [EMAIL PROTECTED] writes: If I move math.h down after postgres.h in nodeHash.c, the problem goes away. Bruce, you broke it. Have you forgotten the fundamental inclusion rule? postgres.h (or postgres_fe.h, or c.h) first, then system headers, then our own other headers. regards, tom lane -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [HACKERS] AIX buildfarm failure
Now it dies on nodeSubplan.c... I am guessing there will be others as well. Perhaps a check to make sure postgres.h is first in the includes can be added to the include checking scripts you have been updating? Thanks, -rocco -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Thursday, July 13, 2006 4:14 PM To: Tom Lane Cc: Rocco Altier; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] AIX buildfarm failure Fixed. -- - Tom Lane wrote: Rocco Altier [EMAIL PROTECTED] writes: If I move math.h down after postgres.h in nodeHash.c, the problem goes away. Bruce, you broke it. Have you forgotten the fundamental inclusion rule? postgres.h (or postgres_fe.h, or c.h) first, then system headers, then our own other headers. regards, tom lane -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [HACKERS] AIX buildfarm failure
Rocco Altier wrote: Now it dies on nodeSubplan.c... I am guessing there will be others as well. I check them all the math.h mentions. --- Perhaps a check to make sure postgres.h is first in the includes can be added to the include checking scripts you have been updating? Thanks, -rocco -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Thursday, July 13, 2006 4:14 PM To: Tom Lane Cc: Rocco Altier; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] AIX buildfarm failure Fixed. -- - Tom Lane wrote: Rocco Altier [EMAIL PROTECTED] writes: If I move math.h down after postgres.h in nodeHash.c, the problem goes away. Bruce, you broke it. Have you forgotten the fundamental inclusion rule? postgres.h (or postgres_fe.h, or c.h) first, then system headers, then our own other headers. regards, tom lane -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
