Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-28 Thread Simon Riggs
On 24 June 2013 22:17, Simon Riggs si...@2ndquadrant.com wrote: On 24 June 2013 21:42, Jeff Janes jeff.ja...@gmail.com wrote: On Sun, Jun 23, 2013 at 8:58 PM, Abhijit Menon-Sen a...@2ndquadrant.comwrote: At 2013-06-08 21:45:24 +0100, si...@2ndquadrant.com wrote: ALTER TABLE foo

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-28 Thread Alvaro Herrera
Simon Riggs escribió: Looks like that really is a deficiency in my tool chain on OSX, rather than some bug/user error. Even at the very latest, very shiny version. Latest versions of gcc trap the error, so I'll have to investigate an alternative. Funnily enough, on Debian Wheezy with gcc

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-24 Thread Jeff Janes
On Sun, Jun 23, 2013 at 8:58 PM, Abhijit Menon-Sen a...@2ndquadrant.comwrote: At 2013-06-08 21:45:24 +0100, si...@2ndquadrant.com wrote: ALTER TABLE foo ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE; I read the patch (looks good), applied it on HEAD (fine), ran make

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-24 Thread Simon Riggs
On 24 June 2013 21:42, Jeff Janes jeff.ja...@gmail.com wrote: On Sun, Jun 23, 2013 at 8:58 PM, Abhijit Menon-Sen a...@2ndquadrant.comwrote: At 2013-06-08 21:45:24 +0100, si...@2ndquadrant.com wrote: ALTER TABLE foo ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE; I

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-23 Thread Abhijit Menon-Sen
At 2013-06-08 21:45:24 +0100, si...@2ndquadrant.com wrote: ALTER TABLE foo ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE; I read the patch (looks good), applied it on HEAD (fine), ran make check (fine), and played with it in a test database. It looks great, and from previous

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-10 Thread Dimitri Fontaine
Andres Freund and...@2ndquadrant.com writes: I haven't looked at the patch in detail, but I am very, very much in favor of the feature in general… I have wished for this more than once, +1 -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-10 Thread Michael Paquier
On Mon, Jun 10, 2013 at 11:06 PM, Dimitri Fontaine dimi...@2ndquadrant.frwrote: Andres Freund and...@2ndquadrant.com writes: I haven't looked at the patch in detail, but I am very, very much in favor of the feature in general… I have wished for this more than once, +1 +1. It will be

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-09 Thread Andres Freund
On 2013-06-08 21:45:24 +0100, Simon Riggs wrote: While fiddling with FK tuning, it was useful to be able to enable and disable the DEFERRED mode of constraints. That is not currently possible in SQL, so I wrote this patch. Without this you have to drop and then re-add a constraint, which is

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-09 Thread Kevin Grittner
Andres Freund and...@2ndquadrant.com wrote: On 2013-06-08 21:45:24 +0100, Simon Riggs wrote: ALTER TABLE foo ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE; I haven't looked at the patch in detail, but I am very, very much in favor of the feature in general… I have wished

[HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-08 Thread Simon Riggs
While fiddling with FK tuning, it was useful to be able to enable and disable the DEFERRED mode of constraints. That is not currently possible in SQL, so I wrote this patch. Without this you have to drop and then re-add a constraint, which is impractical for large tables. e.g. CREATE TABLE