On 2015/10/28 20:10, Robert Haas wrote:
On Fri, Oct 23, 2015 at 11:51 AM, Etsuro Fujita
wrote:
BTW, I found an incorrect error message in ATWrongRelkindError. Attached is
a patch for fixing the message.
Committed and back-patched to 9.3.
Thanks!
Best regards,
Etsuro Fujita
--
Sent via
On Mon, Oct 26, 2015 at 3:12 AM, Amit Langote
wrote:
> On 2015/10/23 19:02, Amit Langote wrote:
>> On 2015/10/23 18:51, Etsuro Fujita wrote:
>>>
>>> This is really really nitpicking, but I noticed that there is an implicit
>>> rule concerning the message format in ATWrongRelkindError; if more than
On Fri, Oct 23, 2015 at 11:51 AM, Etsuro Fujita
wrote:
> BTW, I found an incorrect error message in ATWrongRelkindError. Attached is
> a patch for fixing the message.
Committed and back-patched to 9.3.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 2015/10/23 19:02, Amit Langote wrote:
> On 2015/10/23 18:51, Etsuro Fujita wrote:
>>
>> This is really really nitpicking, but I noticed that there is an implicit
>> rule concerning the message format in ATWrongRelkindError; if more than
>> two objects are present, the message is "\"%s\" is not a
On 2015/10/23 18:51, Etsuro Fujita wrote:
> On 2015/10/23 6:06, Robert Haas wrote:
>> Good catch. Committed and back-patched to 9.5.
>
> Thanks, Amit and Robert!
>
> This is really really nitpicking, but I noticed that there is an implicit
> rule concerning the message format in ATWrongRelkindEr
On 2015/10/23 6:06, Robert Haas wrote:
On Wed, Oct 21, 2015 at 1:51 AM, Amit Langote
wrote:
This may just be nitpicking but I noticed that ATWrongRelkindError() could
emit a better message in case of such errors during ALTER COLUMN DEFAULT
and ALTER COLUMN SET STORAGE than "%s is of the wrong
On 2015/10/23 6:06, Robert Haas wrote:
> On Wed, Oct 21, 2015 at 1:51 AM, Amit Langote
> wrote:
>> Attached adds those.
>
> Good catch. Committed and back-patched to 9.5.
>
> (Yes, one of these problems goes back to 9.3, but it's a minor issue
> so I didn't bother. If someone really feels the
On Wed, Oct 21, 2015 at 1:51 AM, Amit Langote
wrote:
> This may just be nitpicking but I noticed that ATWrongRelkindError() could
> emit a better message in case of such errors during ALTER COLUMN DEFAULT
> and ALTER COLUMN SET STORAGE than "%s is of the wrong type" which is what
> it would emit
Hi,
This may just be nitpicking but I noticed that ATWrongRelkindError() could
emit a better message in case of such errors during ALTER COLUMN DEFAULT
and ALTER COLUMN SET STORAGE than "%s is of the wrong type" which is what
it would emit now. Just need to add a couple of cases to the switch the
