Re: [HACKERS] Add YAML option to explain
Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp wrote: My rewrite is relatively large. Please reversely-review the patch. I rethink the code cleanup should be done with another patch even if needed. Here is a lite version of yaml YAML explan patch. All of the logic for indent is done in ExplainYAMLLineStarting(). It can remove undesirable linebreaks from the item list and end of output. Please check whether the v3.1 patch works as your expectation. If ok, we can move it to Ready for Committer. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center yaml.explain.v3.1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
Greg Sabino Mullane g...@turnstep.com wrote:
On 08/28/2009 02:16 PM, Greg Sabino Mullane wrote:
Attached patch adds YAML output option to explain:
explain (format YAML) select * from information_schema.columns;
Updated version of the patch attached, fixes two small errors.
I've reviewed your patch. I had a trouble on assertion failure.
Maybe es-indent-- in ExplainEndOutput() is wrong.
TRAP: FailedAssertion(!(es.indent == 0), File: explain.c, Line: 198)
LOG: server process (PID 28750) was terminated by signal 6: Aborted
Second issue is a linebreak at the first line of yaml list.
Can we remove the linebreak between '-' and 'Plan' ?
=# EXPLAIN (format yaml) SELECT * FROM pgbench_accounts;
QUERY PLAN
-
-
Plan:
Node Type: Seq Scan
Relation Name: pgbench_accounts
...
I tried to fix the above issues in the attached v3 patch. I also rewrite
grouping_stack field in ExplainState into a *real* stack variable using
ExplainStateStack struct.
Other changes are only for minor cleanup:
- Normalize es-indent * 2 and 2 * es-indent.
- Adjust posisions of '{' and '}'.
- Rewrite if-expressions to strchr().
My rewrite is relatively large. Please reversely-review the patch.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
yaml.explain.v3.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
On 08/28/2009 02:16 PM, Greg Sabino Mullane wrote:
Attached patch adds YAML output option to explain:
explain (format YAML) select * from information_schema.columns;
Updated version of the patch attached, fixes two small errors.
--
Greg Sabino Mullane g...@turnstep.com
PGP Key: 0x14964AC8 200908310847
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
Index: contrib/auto_explain/auto_explain.c
===
RCS file: /projects/cvsroot/pgsql/contrib/auto_explain/auto_explain.c,v
retrieving revision 1.7
diff -c -r1.7 auto_explain.c
*** contrib/auto_explain/auto_explain.c 10 Aug 2009 05:46:49 - 1.7
--- contrib/auto_explain/auto_explain.c 31 Aug 2009 13:36:41 -
***
*** 29,34
--- 29,35
{text, EXPLAIN_FORMAT_TEXT, false},
{xml, EXPLAIN_FORMAT_XML, false},
{json, EXPLAIN_FORMAT_JSON, false},
+ {yaml, EXPLAIN_FORMAT_YAML, false},
{NULL, 0, false}
};
Index: doc/src/sgml/auto-explain.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/auto-explain.sgml,v
retrieving revision 1.4
diff -c -r1.4 auto-explain.sgml
*** doc/src/sgml/auto-explain.sgml 10 Aug 2009 05:46:50 - 1.4
--- doc/src/sgml/auto-explain.sgml 31 Aug 2009 13:36:41 -
***
*** 114,120
varnameauto_explain.log_format/varname selects the
commandEXPLAIN/ output format to be used.
The allowed values are literaltext/literal, literalxml/literal,
! and literaljson/literal. The default is text.
Only superusers can change this setting.
/para
/listitem
--- 114,120
varnameauto_explain.log_format/varname selects the
commandEXPLAIN/ output format to be used.
The allowed values are literaltext/literal, literalxml/literal,
! literaljson/literal, and literalyaml/literal. The default is text.
Only superusers can change this setting.
/para
/listitem
Index: doc/src/sgml/release-8.5.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/release-8.5.sgml,v
retrieving revision 1.4
diff -c -r1.4 release-8.5.sgml
*** doc/src/sgml/release-8.5.sgml 19 Aug 2009 08:18:48 - 1.4
--- doc/src/sgml/release-8.5.sgml 31 Aug 2009 13:36:41 -
***
*** 96,102
itemizedlist
listitem
para
! EXPLAIN allows output of plans in XML or JSON format for automated
processing of explain plans by analysis or visualization tools.
/para
/listitem
--- 96,102
itemizedlist
listitem
para
! EXPLAIN allows output of plans in XML, JSON, or YAML format for automated
processing of explain plans by analysis or visualization tools.
/para
/listitem
Index: doc/src/sgml/ref/explain.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/explain.sgml,v
retrieving revision 1.46
diff -c -r1.46 explain.sgml
*** doc/src/sgml/ref/explain.sgml 10 Aug 2009 05:46:50 - 1.46
--- doc/src/sgml/ref/explain.sgml 31 Aug 2009 13:36:41 -
***
*** 31,37
refsynopsisdiv
synopsis
! EXPLAIN [ ( { ANALYZE replaceable class=parameterboolean/replaceable | VERBOSE replaceable class=parameterboolean/replaceable | COSTS replaceable class=parameterboolean/replaceable | FORMAT { TEXT | XML | JSON } } [, ...] ) ] replaceable class=parameterstatement/replaceable
EXPLAIN [ ANALYZE ] [ VERBOSE ] replaceable class=parameterstatement/replaceable
/synopsis
/refsynopsisdiv
--- 31,37
refsynopsisdiv
synopsis
! EXPLAIN [ ( { ANALYZE replaceable class=parameterboolean/replaceable | VERBOSE replaceable class=parameterboolean/replaceable | COSTS replaceable class=parameterboolean/replaceable | FORMAT { TEXT | XML | JSON | YAML } } [, ...] ) ] replaceable class=parameterstatement/replaceable
EXPLAIN [ ANALYZE ] [ VERBOSE ] replaceable class=parameterstatement/replaceable
/synopsis
/refsynopsisdiv
***
*** 143,150
termliteralFORMAT/literal/term
listitem
para
! Specify the output format, which can be TEXT, XML, or JSON.
! XML or JSON output contains the same information as the text output
format, but is easier for programs to parse. This parameter defaults to
literalTEXT/literal.
/para
--- 143,150
termliteralFORMAT/literal/term
listitem
para
! Specify the output format, which can be TEXT, XML, JSON, or YAML.
! Non-text output contains the same information as the text output
format, but is easier for programs to parse. This parameter defaults to
literalTEXT/literal.
/para
Index: src/backend/commands/explain.c
Re: [HACKERS] Add YAML option to explain
-BEGIN PGP SIGNED MESSAGE-
Hash: RIPEMD160
Greg, can we see a few examples of the YAML output
compared to both json and text?
Sure. Be warned it will make this email long. Because email may wrap things
funny, I'll post the same thing here:
Query 1:
http://pgsql.privatepaste.com/298pqiSwdH
Note that YAML quotes things like JSON does, but only when the quotes are
needed.
Query 2:
http://pgsql.privatepaste.com/610uDDyMu6
greg=# explain (format text, analyze on) select * from pg_class where relname ~
'x' order by 1,2,3;
QUERY PLAN
-
--
Sort (cost=12.82..13.10 rows=111 width=185) (actual time=1.176..1.401
rows=105 loops=1)
Sort Key: relname, relnamespace, reltype
Sort Method: quicksort Memory: 44kB
- Seq Scan on pg_class (cost=0.00..9.05 rows=111 width=185) (actual
time=0.066..0.828 rows=105 loops=1)
Filter: (relname ~ 'x'::text)
Total runtime: 1.676 ms
greg=# explain (format json, analyze on) select * from pg_class where relname ~
'x' order by 1,2,3;
QUERY PLAN
- ---
[
{
Plan: {
Node Type: Sort,
Startup Cost: 12.82,
Total Cost: 13.10,
Plan Rows: 111,
Plan Width: 185,
Actual Startup Time: 1.152,
Actual Total Time: 1.373,
Actual Rows: 105,
Actual Loops: 1,
Sort Key: [relname, relnamespace, reltype],
Sort Method: quicksort,
Sort Space Used: 44,
Sort Space Type: Memory,
Plans: [
{
Node Type: Seq Scan,
Parent Relationship: Outer,
Relation Name: pg_class,
Alias: pg_class,
Startup Cost: 0.00,
Total Cost: 9.05,
Plan Rows: 111,
Plan Width: 185,
Actual Startup Time: 0.067,
Actual Total Time: 0.817,
Actual Rows: 105,
Actual Loops: 1,
Filter: (relname ~ 'x'::text)
Re: [HACKERS] Add YAML option to explain
Greg Sabino Mullane g...@turnstep.com wrote: - Plan: Node Type: Index Scan Scan Direction: Forward Index Name: pg_class_relname_nsp_index Relation Name: pg_class Alias: pg_class Startup Cost: 0.00 Total Cost: 8.27 Plan Rows: 1 Plan Width: 0 Actual Startup Time: 0.019 Actual Total Time: 0.019 Actual Rows: 0 Actual Loops: 1 Index Cond: (relname = 'foo\bar\'::name) Triggers: Total Runtime: 0.058 +1 for including this format. On a ten point scale for human readability, I'd give this about a nine. It's something I'd be comfortable generating in order to annotate and include in an email to programmers or managers who wouldn't have a clue how to read the current text version of a plan. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
On Mon, Aug 31, 2009 at 02:15:08PM -, Greg Sabino Mullane wrote:
Greg, can we see a few examples of the YAML output
compared to both json and text?
...
greg=# explain (format json, analyze on) select * from pg_class where relname
~ 'x' order by 1,2,3;
QUERY PLAN
- ---
An interesting property of json, it is almost exactly the same as python
data structure syntax. If I paste the following into python:
plan = [
{
Plan: {
Node Type: Sort,
Startup Cost: 12.82,
Total Cost: 13.10,
Plan Rows: 111,
Plan Width: 185,
Actual Startup Time: 1.152,
Actual Total Time: 1.373,
Actual Rows: 105,
Actual Loops: 1,
Sort Key: [relname, relnamespace, reltype],
Sort Method: quicksort,
Sort Space Used: 44,
Sort Space Type: Memory,
Plans: [
{
Node Type: Seq Scan,
Parent Relationship: Outer,
Relation Name: pg_class,
Alias: pg_class,
Startup Cost: 0.00,
Total Cost: 9.05,
Plan Rows: 111,
Plan Width: 185,
Actual Startup Time: 0.067,
Actual Total Time: 0.817,
Actual Rows: 105,
Actual Loops: 1,
Filter: (relname ~ 'x'::text)
}
]
},
Triggers: [
],
Total Runtime: 1.649
}
]
I get a python data structure. Which can be manipulated directly, or pretty
printed:
import pprint
pprint.pprint(plan)
[{'Plan': {'Actual Loops': 1,
'Actual Rows': 105,
'Actual Startup Time': 1.1519,
'Actual Total Time': 1.373,
'Node Type': 'Sort',
'Plan Rows': 111,
'Plan Width': 185,
'Plans': [{'Actual Loops': 1,
'Actual Rows': 105,
'Actual Startup Time': 0.067004,
'Actual Total Time': 0.81695,
'Alias': 'pg_class',
'Filter': (relname ~ 'x'::text),
'Node Type': 'Seq Scan',
'Parent Relationship': 'Outer',
'Plan Rows': 111,
'Plan Width': 185,
'Relation Name': 'pg_class',
'Startup Cost': 0.0,
'Total Cost': 9.0507}],
'Sort Key': ['relname', 'relnamespace', 'reltype'],
'Sort Method': 'quicksort',
'Sort Space Type': 'Memory',
'Sort Space Used': 44,
'Startup Cost': 12.82,
'Total Cost': 13.1},
'Total Runtime': 1.649,
'Triggers': []}]
I'm not sure if all json can be read this way, but the python and json
notations are very similar.
-dg
--
David Gould da...@sonic.net 510 536 1443510 282 0869
If simplicity worked, the world would be overrun with insects.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Add YAML option to explain
Attached patch adds YAML output option to explain:
explain (format YAML) select * from information_schema.columns;
--
Greg Sabino Mullane g...@turnstep.com
PGP Key: 0x14964AC8 200908281414
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
Index: contrib/auto_explain/auto_explain.c
===
RCS file: /projects/cvsroot/pgsql/contrib/auto_explain/auto_explain.c,v
retrieving revision 1.7
diff -u -r1.7 auto_explain.c
--- contrib/auto_explain/auto_explain.c 10 Aug 2009 05:46:49 - 1.7
+++ contrib/auto_explain/auto_explain.c 28 Aug 2009 18:12:49 -
@@ -29,6 +29,7 @@
{text, EXPLAIN_FORMAT_TEXT, false},
{xml, EXPLAIN_FORMAT_XML, false},
{json, EXPLAIN_FORMAT_JSON, false},
+{yaml, EXPLAIN_FORMAT_YAML, false},
{NULL, 0, false}
};
Index: doc/src/sgml/auto-explain.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/auto-explain.sgml,v
retrieving revision 1.4
diff -u -r1.4 auto-explain.sgml
--- doc/src/sgml/auto-explain.sgml 10 Aug 2009 05:46:50 - 1.4
+++ doc/src/sgml/auto-explain.sgml 28 Aug 2009 18:12:49 -
@@ -114,7 +114,7 @@
varnameauto_explain.log_format/varname selects the
commandEXPLAIN/ output format to be used.
The allowed values are literaltext/literal, literalxml/literal,
- and literaljson/literal. The default is text.
+ literaljson/literal, and literalyaml/literal. The default is text.
Only superusers can change this setting.
/para
/listitem
Index: doc/src/sgml/release-8.5.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/release-8.5.sgml,v
retrieving revision 1.4
diff -u -r1.4 release-8.5.sgml
--- doc/src/sgml/release-8.5.sgml 19 Aug 2009 08:18:48 - 1.4
+++ doc/src/sgml/release-8.5.sgml 28 Aug 2009 18:12:49 -
@@ -96,7 +96,7 @@
itemizedlist
listitem
para
-EXPLAIN allows output of plans in XML or JSON format for automated
+EXPLAIN allows output of plans in XML, JSON, or YAML format for automated
processing of explain plans by analysis or visualization tools.
/para
/listitem
Index: doc/src/sgml/ref/explain.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/explain.sgml,v
retrieving revision 1.46
diff -u -r1.46 explain.sgml
--- doc/src/sgml/ref/explain.sgml 10 Aug 2009 05:46:50 - 1.46
+++ doc/src/sgml/ref/explain.sgml 28 Aug 2009 18:12:49 -
@@ -31,7 +31,7 @@
refsynopsisdiv
synopsis
-EXPLAIN [ ( { ANALYZE replaceable class=parameterboolean/replaceable | VERBOSE replaceable class=parameterboolean/replaceable | COSTS replaceable class=parameterboolean/replaceable | FORMAT { TEXT | XML | JSON } } [, ...] ) ] replaceable class=parameterstatement/replaceable
+EXPLAIN [ ( { ANALYZE replaceable class=parameterboolean/replaceable | VERBOSE replaceable class=parameterboolean/replaceable | COSTS replaceable class=parameterboolean/replaceable | FORMAT { TEXT | XML | JSON | YAML } } [, ...] ) ] replaceable class=parameterstatement/replaceable
EXPLAIN [ ANALYZE ] [ VERBOSE ] replaceable class=parameterstatement/replaceable
/synopsis
/refsynopsisdiv
@@ -143,8 +143,8 @@
termliteralFORMAT/literal/term
listitem
para
- Specify the output format, which can be TEXT, XML, or JSON.
- XML or JSON output contains the same information as the text output
+ Specify the output format, which can be TEXT, XML, JSON, or YAML.
+ Non-text output contains the same information as the text output
format, but is easier for programs to parse. This parameter defaults to
literalTEXT/literal.
/para
Index: src/backend/commands/explain.c
===
RCS file: /projects/cvsroot/pgsql/src/backend/commands/explain.c,v
retrieving revision 1.190
diff -u -r1.190 explain.c
--- src/backend/commands/explain.c 22 Aug 2009 02:06:32 - 1.190
+++ src/backend/commands/explain.c 28 Aug 2009 18:12:49 -
@@ -96,6 +96,7 @@
static void ExplainXMLTag(const char *tagname, int flags, ExplainState *es);
static void ExplainJSONLineEnding(ExplainState *es);
static void escape_json(StringInfo buf, const char *str);
+static void escape_yaml(StringInfo buf, const char *str);
/*
@@ -137,6 +138,8 @@
es.format = EXPLAIN_FORMAT_XML;
else if (strcmp(p, json) == 0)
es.format = EXPLAIN_FORMAT_JSON;
+ else if (strcmp(p, yaml) == 0)
+es.format = EXPLAIN_FORMAT_YAML;
else
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
@@ -1509,6 +1512,18 @@
}
appendStringInfoChar(es-str, ']');
break;
+
+ case EXPLAIN_FORMAT_YAML:
+ appendStringInfoSpaces(es-str, es-indent * 2);
+ appendStringInfo(es-str, %s:\n,
Re: [HACKERS] Add YAML option to explain
Greg Sabino Mullane wrote: Attached patch adds YAML output option to explain: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. By the way, Magnus pointed out an error in the patch: the hunk at - -1693,7 +1736,6 should be ignored. - -- Greg Sabino Mullane g...@turnstep.com PGP Key: 0x14964AC8 200908281552 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iEYEAREDAAYFAkqYOmUACgkQvJuQZxSWSsjMogCfVV8hj0QkRQFmOq2nkUV+1bqM QDcAoKAlc6lpuV9jbeIL8ms9HIfhLF2W =nb+s -END PGP SIGNATURE- -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
* Greg Sabino Mullane: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. But YAML is much more difficult to parse than JSON. Anybody who can afford a YAML parser can also afford a JSON parser, it is miniscule in comparison. 8-) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
On 8/28/09 1:13 PM, Greg Sabino Mullane wrote: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. How many lines of code does YAML support add to the codebase? While I personally like YAML, it's not like it has broad industry support. And people wouldn't interface with the XML or JSON directly; they'd use a library for that. That's the whole point of having those outputs. -- Josh Berkus PostgreSQL Experts Inc. www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
On Fri, 2009-08-28 at 14:23 -0700, Josh Berkus wrote: On 8/28/09 1:13 PM, Greg Sabino Mullane wrote: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. How many lines of code does YAML support add to the codebase? While I personally like YAML, it's not like it has broad industry support. And people wouldn't interface with the XML or JSON directly; they'd use a library for that. That's the whole point of having those outputs. I am not keen on having YAML support. Joshua D. Drake -- PostgreSQL.org Major Contributor Command Prompt, Inc: http://www.commandprompt.com/ - 503.667.4564 Consulting, Training, Support, Custom Development, Engineering -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
On fre, 2009-08-28 at 20:13 +, Greg Sabino Mullane wrote: Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. But these are supposed to be machine-readable formats. So readability and editability are not high priority criteria. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 How many lines of code does YAML support add to the codebase? About 80. While I personally like YAML, it's not like it has broad industry support. And people wouldn't interface with the XML or JSON directly; they'd use a library for that. That's the whole point of having those outputs. Not sure how one measures broad industry support or why we would care that much. Nor do I wish to turn this thread into a YAML flamewar. It's a small patch that should be useful to the many people that prefer to program using YAML. - -- Greg Sabino Mullane g...@turnstep.com PGP Key: 0x14964AC8 200908281741 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iEYEAREDAAYFAkqYT0QACgkQvJuQZxSWSshPMACg+ho+gTxeKR27pOJrbX7kTJ9E kZIAnRIz57KzuLAAr6PtjupBwletuXRe =ZJO7 -END PGP SIGNATURE- -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
* Greg Sabino Mullane (g...@turnstep.com) wrote: Attached patch adds YAML output option to explain: explain (format YAML) select * from information_schema.columns; +1 from me. I've read the other comments and just plain don't agree with them. It's a small patch, adds a useful format for EXPLAIN, and would be used. One of the best things about PG is the flexibility and usability. Thanks, Stephen signature.asc Description: Digital signature
Re: [HACKERS] Add YAML option to explain
On Aug 28, 2009, at 3:45 PM, Stephen Frost wrote: +1 from me. I've read the other comments and just plain don't agree with them. It's a small patch, adds a useful format for EXPLAIN, and would be used. One of the best things about PG is the flexibility and usability. I agree, I tend to prefer YAML output where it's parseable (and I expect it the EXPLAIN YAML output won't be doing anything tricky). That said, maybe there should be a way to create modules add formats, instead of adding them to core? Best, David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
Peter Eisentraut wrote: On fre, 2009-08-28 at 20:13 +, Greg Sabino Mullane wrote: Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. But these are supposed to be machine-readable formats. So readability and editability are not high priority criteria. Greg, can we see a few examples of the YAML output compared to both json and text? IMVHO, an advantage of YAML is human readability of structured data even compared to most non-computer-parseable human-intended text formats. But maybe that's just because I read too much yaml. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Add YAML option to explain
On Fri, Aug 28, 2009 at 04:37:41PM -0700, David E. Wheeler wrote: On Aug 28, 2009, at 3:45 PM, Stephen Frost wrote: +1 from me. I've read the other comments and just plain don't agree with them. It's a small patch, adds a useful format for EXPLAIN, and would be used. One of the best things about PG is the flexibility and usability. I agree, I tend to prefer YAML output where it's parseable (and I expect it the EXPLAIN YAML output won't be doing anything tricky). That said, maybe there should be a way to create modules add formats, instead of adding them to core? +1 -dg -- David Gould da...@sonic.net 510 536 1443510 282 0869 If simplicity worked, the world would be overrun with insects. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
