Re: [HACKERS] Add visibility map information to pg_freespace.

2013-07-18 Thread Kyotaro HORIGUCHI
Thank you for the worthwhile additions. At Tue, 16 Jul 2013 16:04:43 +0900, Satoshi Nagayasu sn...@uptime.jp wrote in 51e4f08b.3030...@uptime.jp | postgres=# select * from pg_freespace_with_vminfo('t'::regclass) limit | 10; .. I think we can simply add is_all_viible column to the existing

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-07-18 Thread Kyotaro HORIGUCHI
Hmm. I'm sorry to find that this patch is already marked as 'Return with Feedback' on the CF page around the same time when the preveous review comment has sent. Is it somewhat crossing? Anyway, I'll take a rain check for this. I have simply merged the two regtests separately into two original

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-07-16 Thread Satoshi Nagayasu
(2013/07/09 19:55), Kyotaro HORIGUCHI wrote: Hello, I've brought visibilitymap extentions for pg_freespacemap and pgstattuple. At Mon, 08 Jul 2013 16:59:05 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote in

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-07-09 Thread Kyotaro HORIGUCHI
Hello, I've brought visibilitymap extentions for pg_freespacemap and pgstattuple. At Mon, 08 Jul 2013 16:59:05 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote in 20130708.165905.118860769.horiguchi.kyot...@lab.ntt.co.jp I'll come again with the first

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-07-08 Thread Kyotaro HORIGUCHI
Hello, - How about pageinspect? I proposed a simple representation format as a basis for discussion. Nevertheless, the VM pages has no more structure than a simple bit string. Given the VM info in pg_freespacemap, I've come in doubt of the necessity of vm_page_contnets() for

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-07-08 Thread Josh Berkus
On 07/08/2013 12:59 AM, Kyotaro HORIGUCHI wrote: I'll come again with the first implementation of it. And as for pg_freespacemap, I'll keep the current direction - adding column to present output records format of pg_freespace(). And documentation, if possible. Do you think you'll be fixing

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-26 Thread Kyotaro HORIGUCHI
Hello, I'm looking into this patch as a reviewer. I'd appreciate your time to review. I've had some suggestions so far, - I should be cautious in changing existing interface. You're right. It was somehow gone out of my mind. It might be better to provide a separate function from the

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-26 Thread Simon Riggs
On 26 June 2013 09:09, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jpwrote: - How about pageinspect? I proposed a simple representation format as a basis for discussion. Nevertheless, the VM pages has no more structure than a simple bit string. Given the VM info in

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-21 Thread Robert Haas
On Wed, Jun 19, 2013 at 11:26 PM, Satoshi Nagayasu sn...@uptime.jp wrote: - pageinspect provies several functions for debugging purpose. - pg_freespace provies a view for monitoring purpose. - pgstattuple provies several functions for collecting specific table/index statistics. I think we

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-20 Thread Simon Riggs
On 20 June 2013 04:26, Satoshi Nagayasu sn...@uptime.jp wrote: I'm looking into this patch as a reviewer. (2013/06/19 18:03), Simon Riggs wrote: On 19 June 2013 09:19, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: It should useful in other aspects but it seems a bit complicated

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-19 Thread Kyotaro HORIGUCHI
Thank you. This makes sense to me. I only lament the fact that this makes the module a misnomer. Do we want to 1) rename the module (how inconvenient), 2) create a separate module for this (surely not warranted), or 3) accept it and move on? Although I also feel uneasy with the module

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-19 Thread Simon Riggs
On 19 June 2013 09:19, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: It should useful in other aspects but it seems a bit complicated just to know about visibility bits for certain blocks. With your current patch you can only see the visibility info for blocks in cache, not for all

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-19 Thread Andres Freund
On 2013-06-19 10:03:40 +0100, Simon Riggs wrote: On 19 June 2013 09:19, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: It should useful in other aspects but it seems a bit complicated just to know about visibility bits for certain blocks. With your current patch you can only

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-19 Thread Simon Riggs
On 19 June 2013 10:15, Andres Freund and...@2ndquadrant.com wrote: On 2013-06-19 10:03:40 +0100, Simon Riggs wrote: On 19 June 2013 09:19, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: It should useful in other aspects but it seems a bit complicated just to know about visibility

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-19 Thread Satoshi Nagayasu
I'm looking into this patch as a reviewer. (2013/06/19 18:03), Simon Riggs wrote: On 19 June 2013 09:19, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: It should useful in other aspects but it seems a bit complicated just to know about visibility bits for certain blocks. With your

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-15 Thread Simon Riggs
On 14 June 2013 15:22, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Kyotaro HORIGUCHI wrote: Helle, I've added visibility map information to pg_freespace for my utility. This makes sense to me. I only lament the fact that this makes the module a misnomer. Do we want to 1) rename the

[HACKERS] Add visibility map information to pg_freespace.

2013-06-14 Thread Kyotaro HORIGUCHI
Helle, I've added visibility map information to pg_freespace for my utility. This looks like this, postgres=# select * from pg_freespace('t'::regclass); blkno | avail | all_visible ---+---+- 0 | 7424 | t 1 | 7424 | t 2 | 7424 | t 3 | 7424 | t 4

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-14 Thread Alvaro Herrera
Kyotaro HORIGUCHI wrote: Helle, I've added visibility map information to pg_freespace for my utility. This makes sense to me. I only lament the fact that this makes the module a misnomer. Do we want to 1) rename the module (how inconvenient), 2) create a separate module for this (surely

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-14 Thread Andres Freund
On 2013-06-14 10:22:19 -0400, Alvaro Herrera wrote: Kyotaro HORIGUCHI wrote: Helle, I've added visibility map information to pg_freespace for my utility. This makes sense to me. +1 I only lament the fact that this makes the module a misnomer. Do we want to 1) rename the module

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-14 Thread Peter Geoghegan
On Fri, Jun 14, 2013 at 7:23 AM, Andres Freund and...@2ndquadrant.com wrote: 3). All the others seem to inflict unneccesary pain for not all that much gain. +1. You might want to add a historical note about the name to the pg_freespace documentation, though. -- Peter Geoghegan -- Sent via