Re: [HACKERS] Another bug(?) turned up by the llvm optimization checker

2013-11-11 Thread Greg Stark
On Mon, Nov 11, 2013 at 4:00 AM, Tom Lane t...@sss.pgh.pa.us wrote: In any case, the issue looks bigger than just addRangeTableEntry itself. Do you want to write up a patch? I was going to include it in the overflow patch but I'm now thinking I should make it a separate commit to make sure

Re: [HACKERS] Another bug(?) turned up by the llvm optimization checker

2013-11-10 Thread Tom Lane
Greg Stark st...@mit.edu writes: The commit below, specifically the change mentioned in the last paragraph to fix isLockedRel broke the following comment in addRangeTableEntry: * If pstate is NULL, we just build an RTE and return it without adding it * to an rtable list. In fact

[HACKERS] Another bug(?) turned up by the llvm optimization checker

2013-10-08 Thread Greg Stark
The commit below, specifically the change mentioned in the last paragraph to fix isLockedRel broke the following comment in addRangeTableEntry: * If pstate is NULL, we just build an RTE and return it without adding it * to an rtable list. In fact isLockedRefname() will seg fault promptly if