Re: [HACKERS] Behavior for crash recovery when it detects a corrupt WAL record

2012-10-10 Thread Amit Kapila
On Tuesday, October 09, 2012 7:38 PM Heikki Linnakangas wrote: > On 09.10.2012 16:42, Amit Kapila wrote: > > I have observed that currently during recovery, while it applies the > WAL > > records even if it detects that there is a corrupt record > > > > by crc validation, it proceeds. > > > > Basic

Re: [HACKERS] Behavior for crash recovery when it detects a corrupt WAL record

2012-10-10 Thread Heikki Linnakangas
On 10.10.2012 17:37, Amit Kapila wrote: On Tuesday, October 09, 2012 7:38 PM Heikki Linnakangas wrote: We rely on the CRC to detect end of WAL during recovery. If the system crashes while the WAL is being flushed to disk, it's normal that there's a corrupt (ie. partially written) record at the e

Re: [HACKERS] Behavior for crash recovery when it detects a corrupt WAL record

2012-10-09 Thread Heikki Linnakangas
On 09.10.2012 16:42, Amit Kapila wrote: I have observed that currently during recovery, while it applies the WAL records even if it detects that there is a corrupt record by crc validation, it proceeds. Basically ReadRecord(), returns NULL in such cases which makes the behavior same as it has r

[HACKERS] Behavior for crash recovery when it detects a corrupt WAL record

2012-10-09 Thread Amit Kapila
I have observed that currently during recovery, while it applies the WAL records even if it detects that there is a corrupt record by crc validation, it proceeds. Basically ReadRecord(), returns NULL in such cases which makes the behavior same as it has reached end of WAL. After that server get