Re: [HACKERS] Better to dump tabs as tabs, or \t?

2006-05-27 Thread Bruce Momjian
COPY wants \r and \n to be used because it checks for line endings, but your change is only for the SQL strings, and you are right, it is more porable to dump as actual bytes than backslashes. --- Tom Lane wrote: > "Marko Kr

Re: [HACKERS] Better to dump tabs as tabs, or \t?

2006-05-27 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 5/27/06, Tom Lane <[EMAIL PROTECTED]> wrote: >> Historically pg_dump has taken pains to dump ASCII control characters >> as backslash constructs, for instance \t for tab. I am thinking this >> is not such a great idea, and that it'd be more portable r

Re: [HACKERS] Better to dump tabs as tabs, or \t?

2006-05-27 Thread Marko Kreen
On 5/27/06, Tom Lane <[EMAIL PROTECTED]> wrote: Historically pg_dump has taken pains to dump ASCII control characters as backslash constructs, for instance \t for tab. I am thinking this is not such a great idea, and that it'd be more portable rather than less so if we got rid of that logic and

Re: [HACKERS] Better to dump tabs as tabs, or \t?

2006-05-27 Thread Andrew Dunstan
Tom Lane wrote: Historically pg_dump has taken pains to dump ASCII control characters as backslash constructs, for instance \t for tab. I am thinking this is not such a great idea, and that it'd be more portable rather than less so if we got rid of that logic and just dumped tab as tab, etc. In

[HACKERS] Better to dump tabs as tabs, or \t?

2006-05-27 Thread Tom Lane
Historically pg_dump has taken pains to dump ASCII control characters as backslash constructs, for instance \t for tab. I am thinking this is not such a great idea, and that it'd be more portable rather than less so if we got rid of that logic and just dumped tab as tab, etc. In particular, making