Re: [HACKERS] Breaking compile-time dependency cycles of Postgres subdirs?

2014-02-10 Thread Christian Convey
On Sun, Feb 9, 2014 at 8:06 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Feb 7, 2014 at 7:39 AM, Christian Convey christian.con...@gmail.com wrote: This question is mostly just curiosity... As someone very new to this code base, I think these cycles make it a little harder to

Re: [HACKERS] Breaking compile-time dependency cycles of Postgres subdirs?

2014-02-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Feb 7, 2014 at 7:39 AM, Christian Convey christian.con...@gmail.com wrote: As someone very new to this code base, I think these cycles make it a little harder to figure out the runtime and compile-time dependencies between the subsystems these

Re: [HACKERS] Breaking compile-time dependency cycles of Postgres subdirs?

2014-02-10 Thread Christian Convey
On Mon, Feb 10, 2014 at 10:28 AM, Tom Lane t...@sss.pgh.pa.us wrote: I think if it had been a clear, enforced goal all along, it might've been possible to build the system with such a restriction (for the most part at least). At this point though, the amount of work and code churn involved

Re: [HACKERS] Breaking compile-time dependency cycles of Postgres subdirs?

2014-02-09 Thread Robert Haas
On Fri, Feb 7, 2014 at 7:39 AM, Christian Convey christian.con...@gmail.com wrote: This question is mostly just curiosity... There are build-time dependency cycles between some of Postgres' code subdirectories. For example, storage and access have such a cycle: storage/buffpage.h #includes

[HACKERS] Breaking compile-time dependency cycles of Postgres subdirs?

2014-02-07 Thread Christian Convey
This question is mostly just curiosity... There are build-time dependency cycles between some of Postgres' code subdirectories. For example, storage and access have such a cycle: storage/buffpage.h #includes access/xlogdefs.h access/visibilitymap.h #includes storage/block.h Has there been any