Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Tom Lane <[EMAIL PROTECTED]> writes: >> Where are we going to find a representative test set of >> dozen-or-more- way SQL join queries? > As far as getting good lotsa-join queries, I think we can either: >(1) generate the queries programmatically >

Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread Neil Conway
Tom Lane <[EMAIL PROTECTED]> writes: > Where are we going to find a representative test set of > dozen-or-more- way SQL join queries? Interesting that you should mention that. I've been thinking for a while that we need a much more extensive test suite for the query optimizer. This would allow us

Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Tom Lane <[EMAIL PROTECTED]> writes: >> I'm assuming that the original author of the GEQO code already did >> that testing ... > Removing the code without bothering to verify this assumption is a > little unwise, IMHO: Fair enough. I did a little bit of

Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread Neil Conway
Tom Lane <[EMAIL PROTECTED]> writes: > I'm assuming that the original author of the GEQO code already did > that testing ... Removing the code without bothering to verify this assumption is a little unwise, IMHO: given the low quality of the rest of the GEQO code, I wouldn't be surprised to learn

Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread Tom Lane
"scott.marlowe" <[EMAIL PROTECTED]> writes: > On Thu, 22 Jan 2004, Tom Lane wrote: >> I'm assuming that the original author of the GEQO code already did that >> testing ... > Hmmm. I was figuring he wasn't sure so he left them in for other people > to test. Is this a part of the code that eats

Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread scott.marlowe
On Thu, 22 Jan 2004, Tom Lane wrote: > "scott.marlowe" <[EMAIL PROTECTED]> writes: > > On Wed, 21 Jan 2004, Tom Lane wrote: > >> The GEQO planner module contains six different recombination algorithms, > > > considering the recent discussion about REALLY slow query planning by the > > GEQO modul

Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread Tom Lane
"scott.marlowe" <[EMAIL PROTECTED]> writes: > On Wed, 21 Jan 2004, Tom Lane wrote: >> The GEQO planner module contains six different recombination algorithms, > considering the recent discussion about REALLY slow query planning by the > GEQO module, it might be worth testing each one to see which

Re: [HACKERS] Bunch o' dead code in GEQO

2004-01-22 Thread scott.marlowe
On Wed, 21 Jan 2004, Tom Lane wrote: > The GEQO planner module contains six different recombination algorithms, > only one of which is actually used --- the others are ifdef'd out, and > have been ever since we got the code. Does anyone see a reason not to > prune the deadwood? considering the r

[HACKERS] Bunch o' dead code in GEQO

2004-01-21 Thread Tom Lane
The GEQO planner module contains six different recombination algorithms, only one of which is actually used --- the others are ifdef'd out, and have been ever since we got the code. Does anyone see a reason not to prune the deadwood? regards, tom lane