Re: [HACKERS] Cannot use all four trigger events at once

2009-06-18 Thread Simon Riggs
On Wed, 2009-06-17 at 16:22 -0400, Greg Sabino Mullane wrote: This was failing: CREATE TRIGGER foo AFTER INSERT OR UPDATE OR DELETE OR TRUNCATE ON foobar FOR EACH STATEMENT EXECUTE PROCEDURE baz(); Turns out the parser wasn't set up to handle four different trigger event types. Patch

[HACKERS] Cannot use all four trigger events at once

2009-06-17 Thread Greg Sabino Mullane
This was failing: CREATE TRIGGER foo AFTER INSERT OR UPDATE OR DELETE OR TRUNCATE ON foobar FOR EACH STATEMENT EXECUTE PROCEDURE baz(); Turns out the parser wasn't set up to handle four different trigger event types. Patch attached. -- Greg Sabino Mullane g...@endpoint.com g...@turnstep.com

Re: [HACKERS] Cannot use all four trigger events at once

2009-06-17 Thread Tom Lane
Greg Sabino Mullane g...@turnstep.com writes: This was failing: CREATE TRIGGER foo AFTER INSERT OR UPDATE OR DELETE OR TRUNCATE ON foobar FOR EACH STATEMENT EXECUTE PROCEDURE baz(); Turns out the parser wasn't set up to handle four different trigger event types. Hmm, that's a problem ...

Re: [HACKERS] Cannot use all four trigger events at once

2009-06-17 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 NotDashEscaped: You need GnuPG to verify this message ... but this patch doesn't come close to fixing it. struct CreateTrigStmt needs changes. I kinda think the

Re: [HACKERS] Cannot use all four trigger events at once

2009-06-17 Thread Tom Lane
Greg Sabino Mullane g...@turnstep.com writes: Thanks. I'll leave the [5] restriction call to someone else, seems it does no harm to me though (not as if we'd change it that often anyway). Revised patch below. I looked through other places that might be affected, but did not see anything else