Re: [HACKERS] Catching resource leaks during WAL replay

2013-03-28 Thread Heikki Linnakangas
On 28.03.2013 01:01, Tom Lane wrote: Simon Riggssi...@2ndquadrant.com writes: On 27 March 2013 20:40, Heikki Linnakangashlinnakan...@vmware.com wrote: While looking at bug #7969, it occurred to me that it would be nice if we could catch resource leaks in WAL redo routines better. It would be

Re: [HACKERS] Catching resource leaks during WAL replay

2013-03-28 Thread Tom Lane
Heikki Linnakangas hlinnakan...@vmware.com writes: On 28.03.2013 01:01, Tom Lane wrote: Simon Riggssi...@2ndquadrant.com writes: I'm inclined to think that the overhead isn't worth the trouble. This is the only bug of its type we had in recent years. I agree that checking for resource leaks

[HACKERS] Catching resource leaks during WAL replay

2013-03-27 Thread Heikki Linnakangas
While looking at bug #7969, it occurred to me that it would be nice if we could catch resource leaks in WAL redo routines better. It would be useful during development, to catch bugs earlier, and it could've turned that replay-stopping error into a warning. For regular transactions, we use

Re: [HACKERS] Catching resource leaks during WAL replay

2013-03-27 Thread Simon Riggs
On 27 March 2013 20:40, Heikki Linnakangas hlinnakan...@vmware.com wrote: While looking at bug #7969, it occurred to me that it would be nice if we could catch resource leaks in WAL redo routines better. It would be useful during development, to catch bugs earlier, and it could've turned that

Re: [HACKERS] Catching resource leaks during WAL replay

2013-03-27 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On 27 March 2013 20:40, Heikki Linnakangas hlinnakan...@vmware.com wrote: While looking at bug #7969, it occurred to me that it would be nice if we could catch resource leaks in WAL redo routines better. It would be useful during development, to catch

Re: [HACKERS] Catching resource leaks during WAL replay

2013-03-27 Thread Simon Riggs
On 27 March 2013 23:01, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: On 27 March 2013 20:40, Heikki Linnakangas hlinnakan...@vmware.com wrote: While looking at bug #7969, it occurred to me that it would be nice if we could catch resource leaks in WAL redo