Re: [HACKERS] Cause of recent buildfarm failures on hamerkop

2012-09-14 Thread Tom Lane
Aidan Van Dyk writes: > If we have "text files" that we need to be "binary equivilents" for > the purpose of diffing, we should probably attribute them in git > attributes to make sure they are not considered "text autocrlf'able". > It could be as simple as adding: > *.out-text > *.dat

Re: [HACKERS] Cause of recent buildfarm failures on hamerkop

2012-09-14 Thread Tom Lane
Magnus Hagander writes: > On Fri, Sep 14, 2012 at 7:02 AM, Tom Lane wrote: >> I'm not sure if we should just write this off as pilot error, or if we >> should try to make the regression tests proof against such things. If >> the latter, how exactly? > I don't think we need to make them proof ag

Re: [HACKERS] Cause of recent buildfarm failures on hamerkop

2012-09-14 Thread Aidan Van Dyk
On Fri, Sep 14, 2012 at 4:56 AM, Magnus Hagander wrote: >> I assume this means that the git checkout was created with options that >> allowed conversion of text files to \r\n line endings. If we have "text files" that we need to be "binary equivilents" for the purpose of diffing, we should proba

Re: [HACKERS] Cause of recent buildfarm failures on hamerkop

2012-09-14 Thread Magnus Hagander
On Fri, Sep 14, 2012 at 7:02 AM, Tom Lane wrote: > I looked into why buildfarm member hamerkop has been failing regression > tests for the last two months. The symptoms appear consistent with the > theory that the src/test/regress/data/tenk.data test file has been > converted to have DOS style li

[HACKERS] Cause of recent buildfarm failures on hamerkop

2012-09-13 Thread Tom Lane
I looked into why buildfarm member hamerkop has been failing regression tests for the last two months. The symptoms appear consistent with the theory that the src/test/regress/data/tenk.data test file has been converted to have DOS style line endings (\r\n). The test cases that are failing involv