Re: [HACKERS] Change format of FDW options used in \d* commands

2011-08-25 Thread Robert Haas
2011/8/19 Shigeru Hanada : > Oops, good catch.  I've fixed psql to use quote_ident() for option_name, > and modified regression tests to use special characters in option names. >  Please try revised version of patch. This part looks good to me, too. Committed. -- Robert Haas EnterpriseDB: http:

Re: [HACKERS] Change format of FDW options used in \d* commands

2011-08-25 Thread Robert Haas
2011/8/19 Shigeru Hanada : > BTW, I noticed that pg_dump has same issue since 8.4, initial release of > SQL/MED infrastructure.  If a FDW option was defined on any FDW object > with a name which contains one of special characters such as space and > parentheses, pg_dump generates invalid OPTIONS cl

Re: [HACKERS] Change format of FDW options used in \d* commands

2011-08-18 Thread Robert Haas
2011/8/18 Shigeru Hanada : > Thanks for the review. > > (2011/08/13 3:59), Robert Haas wrote: >> IMHO, the new format should put parentheses around the options list. > > Agreed.  Revised version of patch has been attached.  This version puts > parentheses around FDW option only when it was not NULL