Re: [HACKERS] Changeset Extraction v7.5

2014-02-12 Thread Andres Freund
On 2014-02-11 11:22:24 -0500, Robert Haas wrote: + context = AllocSetContextCreate(CurrentMemoryContext, + Changeset Extraction Context, + ALLOCSET_DEFAULT_MINSIZE, + ALLOCSET_DEFAULT_INITSIZE, + ALLOCSET_DEFAULT_MAXSIZE); I have my doubts about whether it's wise to make this

Re: [HACKERS] Changeset Extraction v7.5

2014-02-11 Thread Robert Haas
On Fri, Feb 7, 2014 at 2:35 PM, Andres Freund and...@2ndquadrant.com wrote: attached you can find the next version of the patchset. As usual, I'm going to be reviewing patch 1. The definition of patch 1 has changed quite a few times over the past year, but that's usually the one I'm reviewing.

Re: [HACKERS] Changeset Extraction v7.5

2014-02-11 Thread Andres Freund
Hi! On 2014-02-11 11:22:24 -0500, Robert Haas wrote: + * contents of records in here xexcept turning them into a more usable Typo. + /* +* XXX: There doesn't seem to be a usecase for decoding +* HEAP_NEWPAGE's.

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Andres Freund
Hi, Only got to this now, was a bit too tired and needed to catch up on some real-world stuff... On 2014-02-08 00:16:07 +, Thom Brown wrote: On 7 February 2014 23:43, Andres Freund and...@2ndquadrant.com wrote: Thanks, that's a bug indeed. I have experimentally fixed the bug, not sure

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Thom Brown
On 8 February 2014 17:52, Andres Freund and...@2ndquadrant.com wrote: Hi, Only got to this now, was a bit too tired and needed to catch up on some real-world stuff... On 2014-02-08 00:16:07 +, Thom Brown wrote: On 7 February 2014 23:43, Andres Freund and...@2ndquadrant.com wrote:

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Thom Brown
On 8 February 2014 19:35, Thom Brown t...@linux.com wrote: On 8 February 2014 17:52, Andres Freund and...@2ndquadrant.com wrote: Hi, Only got to this now, was a bit too tired and needed to catch up on some real-world stuff... On 2014-02-08 00:16:07 +, Thom Brown wrote: On 7 February

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Andres Freund
On 2014-02-08 21:07:03 +, Thom Brown wrote: I'll continue to play around with the feature. Next issue. Firstly, an out-of-date example: doc/src/sgml/changesetextraction.sgml pg_recvlogical --slot test --init -d testdb There's no option --init. I think this is supposed to be

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Thom Brown
On 8 February 2014 21:25, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-08 21:07:03 +, Thom Brown wrote: I'll continue to play around with the feature. Next issue. Firstly, an out-of-date example: doc/src/sgml/changesetextraction.sgml pg_recvlogical --slot test --init -d

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Andres Freund
Hi Thom, On 2014-02-08 22:26:59 +, Thom Brown wrote: Got a question about ranges and arrays usage with timestamps... why are quotes added to these? timestamptz (no quotes with input or output): table a: INSERT: moo[timestamptz]:2014-02-08 22:09:33+00 tstzrange (no quotes with input,

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Thom Brown
On 8 February 2014 22:47, Andres Freund and...@2ndquadrant.com wrote: Hi Thom, On 2014-02-08 22:26:59 +, Thom Brown wrote: Got a question about ranges and arrays usage with timestamps... why are quotes added to these? timestamptz (no quotes with input or output): table a: INSERT:

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Andres Freund
On 2014-02-08 22:58:35 +, Thom Brown wrote: Another question: in order for logical decoding/replication to be useful, presumably one would need a primary key on every table? It's just I haven't seen this mentioned on the changeset extraction page in the docs. Hm, that's a good point.

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Thom Brown
On 8 February 2014 23:08, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-08 22:58:35 +, Thom Brown wrote: Another question: in order for logical decoding/replication to be useful, presumably one would need a primary key on every table? It's just I haven't seen this mentioned on

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Andres Freund
On 2014-02-09 00:49:31 +, Thom Brown wrote: # ALTER TABLE test ADD COLUMN a decimal DEFAULT 2.22; ALTER TABLE # ALTER TABLE test ADD COLUMN b json DEFAULT '{a:[1,2,3],b:[4,5,6]}'; ALTER TABLE The output generated by those last 2 statements is: BEGIN 891 table pg_temp_16552:

Re: [HACKERS] Changeset Extraction v7.5

2014-02-08 Thread Thom Brown
On 9 February 2014 01:06, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-09 00:49:31 +, Thom Brown wrote: # ALTER TABLE test ADD COLUMN a decimal DEFAULT 2.22; ALTER TABLE # ALTER TABLE test ADD COLUMN b json DEFAULT '{a:[1,2,3],b:[4,5,6]}'; ALTER TABLE The output generated by

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 20:58, Thom Brown t...@linux.com wrote: On 7 February 2014 19:35, Andres Freund and...@2ndquadrant.com wrote: 0004: wal_decoding: Documentation for replication slots and changeset extraction The usage of pg_create_decoding_replication_slot does show the (1 row) line. I

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Andres Freund
On February 7, 2014 9:58:14 PM CET, Thom Brown t...@linux.com wrote: On 7 February 2014 19:35, Andres Freund and...@2ndquadrant.com wrote: 0004: wal_decoding: Documentation for replication slots and changeset extraction The usage of pg_create_decoding_replication_slot does show the (1 row) line.

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 21:04, Andres Freund and...@2ndquadrant.com wrote: On February 7, 2014 9:58:14 PM CET, Thom Brown t...@linux.com wrote: On 7 February 2014 19:35, Andres Freund and...@2ndquadrant.com wrote: 0004: wal_decoding: Documentation for replication slots and changeset extraction The

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 19:35, Andres Freund and...@2ndquadrant.com wrote: 0004: wal_decoding: Documentation for replication slots and changeset extraction The usage of pg_create_decoding_replication_slot does show the (1 row) line. The output of SELECT * FROM pg_replication_slots; is out-of-date.

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Erik Rijkers
On Fri, February 7, 2014 22:09, Thom Brown wrote: The example also shows output from pg_decoding_slot_get_changes after inserting 2 rows, but when I run the same example, there are no rows FWIW, works for me: testdb=# SELECT * FROM pg_decoding_slot_get_changes('regression_slot', 'now',

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 21:28, Erik Rijkers e...@xs4all.nl wrote: On Fri, February 7, 2014 22:09, Thom Brown wrote: The example also shows output from pg_decoding_slot_get_changes after inserting 2 rows, but when I run the same example, there are no rows FWIW, works for me: Can you confirm you're

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Erik Rijkers
On Fri, February 7, 2014 22:29, Thom Brown wrote: On 7 February 2014 21:28, Erik Rijkers e...@xs4all.nl wrote: On Fri, February 7, 2014 22:09, Thom Brown wrote: The example also shows output from pg_decoding_slot_get_changes after inserting 2 rows, but when I run the same example, there are no

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Andres Freund
On 2014-02-07 20:58:14 +, Thom Brown wrote: On 7 February 2014 19:35, Andres Freund and...@2ndquadrant.com wrote: 0004: wal_decoding: Documentation for replication slots and changeset extraction The usage of pg_create_decoding_replication_slot does show the (1 row) line. The output

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 23:43, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-07 20:58:14 +, Thom Brown wrote: On 7 February 2014 19:35, Andres Freund and...@2ndquadrant.com wrote: 0004: wal_decoding: Documentation for replication slots and changeset extraction The usage of