Re: [HACKERS] Clang compiler warning on 9.3 HEAD

2013-04-11 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Now, it annoys me that we now have three places that know about object > > types supported by event triggers: there's a large struct of command tag > > substrings (event_trigger_support), then there's these two functions. > > It might be better to add O

Re: [HACKERS] Clang compiler warning on 9.3 HEAD

2013-04-05 Thread Dimitri Fontaine
Alvaro Herrera writes: > Now, it annoys me that we now have three places that know about object > types supported by event triggers: there's a large struct of command tag > substrings (event_trigger_support), then there's these two functions. > It might be better to add ObjectType and ObjectClass

Re: [HACKERS] Clang compiler warning on 9.3 HEAD

2013-04-04 Thread Tom Lane
Alvaro Herrera writes: > Now, it annoys me that we now have three places that know about object > types supported by event triggers: there's a large struct of command tag > substrings (event_trigger_support), then there's these two functions. > It might be better to add ObjectType and ObjectClass

Re: [HACKERS] Clang compiler warning on 9.3 HEAD

2013-04-04 Thread Alvaro Herrera
Will Leinweber wrote: > On ref 8507907 when compiling with clang on os x, I got this warning which > seems like a possible bug. > > I thought to report this because I imagine clang isn't frequently used > day-to-day by most. Ugh. My fault. Yes, this is a bug. I don't see any nice way to conver

Re: [HACKERS] Clang compiler warning on 9.3 HEAD

2013-04-03 Thread Peter Geoghegan
On Wed, Apr 3, 2013 at 11:52 PM, Will Leinweber wrote: > On ref 8507907 when compiling with clang on os x, I got this warning which > seems like a possible bug. > > I thought to report this because I imagine clang isn't frequently used > day-to-day by most. I actually reported a bug that was thro

[HACKERS] Clang compiler warning on 9.3 HEAD

2013-04-03 Thread Will Leinweber
On ref 8507907 when compiling with clang on os x, I got this warning which seems like a possible bug. I thought to report this because I imagine clang isn't frequently used day-to-day by most. dependency.c:213:36: warning: implicit conversion from enumeration type 'ObjectClass' (aka 'enum ObjectC