Re: [HACKERS] Comment patch for bgworker.c

2015-02-02 Thread Jim Nasby
On 2/2/15 7:49 AM, Robert Haas wrote: On Fri, Oct 24, 2014 at 8:51 PM, Jim Nasby wrote: The comment for the BackgroundWorkerSlot structure tripped me up reviewing Robert's background worker patch; it made it clear that you need to use a memory barrier before setting in_use, but normally you'd n

Re: [HACKERS] Comment patch for bgworker.c

2015-02-02 Thread Robert Haas
On Fri, Oct 24, 2014 at 8:51 PM, Jim Nasby wrote: > The comment for the BackgroundWorkerSlot structure tripped me up reviewing > Robert's background worker patch; it made it clear that you need to use a > memory barrier before setting in_use, but normally you'd never need to worry > about that bec

[HACKERS] Comment patch for bgworker.c

2014-10-24 Thread Jim Nasby
The comment for the BackgroundWorkerSlot structure tripped me up reviewing Robert's background worker patch; it made it clear that you need to use a memory barrier before setting in_use, but normally you'd never need to worry about that because RegisterDynamicBackgroundWorker() handles it for y