Re: [HACKERS] Compilation failed
On Fri, Feb 4, 2011 at 8:07 AM, Fujii Masao wrote: > On Fri, Feb 4, 2011 at 9:07 PM, Robert Haas wrote: >> On Fri, Feb 4, 2011 at 6:39 AM, Fujii Masao wrote: >>> When I ran "make" before "make install", both successfully >>> finished. So I guess that the "make install" rule in Makefile might >>> be corrupted. >> >> Ah - that's the key. Not corrupted, but missing a dependency. Try it now... > > Thanks! The problem disappeared from my machine. Glad to hear it. But the more I like at this, the more screwed up it seems. make distprep does the wrong thing, and there are some other problems too. Working on it... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compilation failed
On Fri, Feb 4, 2011 at 9:07 PM, Robert Haas wrote: > On Fri, Feb 4, 2011 at 6:39 AM, Fujii Masao wrote: >> When I ran "make" before "make install", both successfully >> finished. So I guess that the "make install" rule in Makefile might >> be corrupted. > > Ah - that's the key. Not corrupted, but missing a dependency. Try it now... Thanks! The problem disappeared from my machine. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compilation failed
On Fri, Feb 4, 2011 at 6:39 AM, Fujii Masao wrote: > When I ran "make" before "make install", both successfully > finished. So I guess that the "make install" rule in Makefile might > be corrupted. Ah - that's the key. Not corrupted, but missing a dependency. Try it now... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compilation failed
On Fri, Feb 4, 2011 at 06:19, Robert Haas wrote: > On Fri, Feb 4, 2011 at 12:11 AM, Robert Haas wrote: >> On Thu, Feb 3, 2011 at 11:42 PM, Robert Haas wrote: >>> On Thu, Feb 3, 2011 at 11:02 PM, Fujii Masao wrote: Hi, When I run "git pull" from the git master and "make", I encountered the following compilation error. gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -g -I../../src/port -I../../src/include -D_GNU_SOURCE -c chklocale.c -o chklocale_srv.o In file included from ../../src/include/postgres.h:48, from chklocale.c:17: ../../src/include/utils/elog.h:69:28: error: utils/errcodes.h: No such file or directory make[2]: *** [chklocale_srv.o] Error 1 make[2]: Leaving directory `/home/postgres/head/src/port' make[1]: *** [install-port-recurse] Error 2 make[1]: Leaving directory `/home/postgres/head/src' make: *** [install-src-recurse] Error 2 I guess the following commit causes a problem. - Avoid maintaining three separate copies of the error codes list. src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a big chunk of errcodes.sgml are now automatically generated from a single file, src/backend/utils/errcodes.txt. - >>> >>> The build farm doesn't look too happy with it either, but of course it >>> worked for me here. I guess there's a missing dependency somewhere. >>> >>> *goes off to look* >> >> I just pushed some fixes to unbreak the VPATH build (I hope) but I >> don't see exactly what's going wrong to cause you the problem shown >> above. Can you try with a completely fresh tree and send the whole >> build log if it's still failing? > > MSVC isn't happy with this either: > > Writing fmgroids.h > Writing fmgrtab.c > Generating probes.h... > Generating errcodes.h... > The filename, directory name, or volume label syntax is incorrect. > Could not open src\backend\utils\errcodes.h at > src/tools/msvc/Mkvcbuild.pm line 463 > > I can't immediately grok what I need to do to fix that. I think it's because it's using double quotes and then backslashes in the filenames, which will apply escaping. I've changed it to single quotes and hope that will fix it - the firewall at the airport here is blocking my outbound RDP so I can't verify it now - if it doesn't work, I'll take another look later. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compilation failed
On Fri, Feb 4, 2011 at 12:11 AM, Robert Haas wrote: > On Thu, Feb 3, 2011 at 11:42 PM, Robert Haas wrote: >> On Thu, Feb 3, 2011 at 11:02 PM, Fujii Masao wrote: >>> Hi, >>> >>> When I run "git pull" from the git master and "make", I encountered >>> the following compilation error. >>> >>> gcc -Wall -Wmissing-prototypes -Wpointer-arith >>> -Wdeclaration-after-statement -Wendif-labels -Wformat-security >>> -fno-strict-aliasing -fwrapv -g -I../../src/port -I../../src/include >>> -D_GNU_SOURCE -c chklocale.c -o chklocale_srv.o >>> In file included from ../../src/include/postgres.h:48, >>> from chklocale.c:17: >>> ../../src/include/utils/elog.h:69:28: error: utils/errcodes.h: No such >>> file or directory >>> make[2]: *** [chklocale_srv.o] Error 1 >>> make[2]: Leaving directory `/home/postgres/head/src/port' >>> make[1]: *** [install-port-recurse] Error 2 >>> make[1]: Leaving directory `/home/postgres/head/src' >>> make: *** [install-src-recurse] Error 2 >>> >>> >>> I guess the following commit causes a problem. >>> >>> - >>> Avoid maintaining three separate copies of the error codes list. >>> >>> src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a >>> big chunk of errcodes.sgml are now automatically generated from a single >>> file, src/backend/utils/errcodes.txt. >>> - >> >> The build farm doesn't look too happy with it either, but of course it >> worked for me here. I guess there's a missing dependency somewhere. >> >> *goes off to look* > > I just pushed some fixes to unbreak the VPATH build (I hope) but I > don't see exactly what's going wrong to cause you the problem shown > above. Can you try with a completely fresh tree and send the whole > build log if it's still failing? MSVC isn't happy with this either: Writing fmgroids.h Writing fmgrtab.c Generating probes.h... Generating errcodes.h... The filename, directory name, or volume label syntax is incorrect. Could not open src\backend\utils\errcodes.h at src/tools/msvc/Mkvcbuild.pm line 463 I can't immediately grok what I need to do to fix that. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compilation failed
On Thu, Feb 3, 2011 at 11:42 PM, Robert Haas wrote: > On Thu, Feb 3, 2011 at 11:02 PM, Fujii Masao wrote: >> Hi, >> >> When I run "git pull" from the git master and "make", I encountered >> the following compilation error. >> >> gcc -Wall -Wmissing-prototypes -Wpointer-arith >> -Wdeclaration-after-statement -Wendif-labels -Wformat-security >> -fno-strict-aliasing -fwrapv -g -I../../src/port -I../../src/include >> -D_GNU_SOURCE -c chklocale.c -o chklocale_srv.o >> In file included from ../../src/include/postgres.h:48, >> from chklocale.c:17: >> ../../src/include/utils/elog.h:69:28: error: utils/errcodes.h: No such >> file or directory >> make[2]: *** [chklocale_srv.o] Error 1 >> make[2]: Leaving directory `/home/postgres/head/src/port' >> make[1]: *** [install-port-recurse] Error 2 >> make[1]: Leaving directory `/home/postgres/head/src' >> make: *** [install-src-recurse] Error 2 >> >> >> I guess the following commit causes a problem. >> >> - >> Avoid maintaining three separate copies of the error codes list. >> >> src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a >> big chunk of errcodes.sgml are now automatically generated from a single >> file, src/backend/utils/errcodes.txt. >> - > > The build farm doesn't look too happy with it either, but of course it > worked for me here. I guess there's a missing dependency somewhere. > > *goes off to look* I just pushed some fixes to unbreak the VPATH build (I hope) but I don't see exactly what's going wrong to cause you the problem shown above. Can you try with a completely fresh tree and send the whole build log if it's still failing? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compilation failed
On Thu, Feb 3, 2011 at 11:02 PM, Fujii Masao wrote: > Hi, > > When I run "git pull" from the git master and "make", I encountered > the following compilation error. > > gcc -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels -Wformat-security > -fno-strict-aliasing -fwrapv -g -I../../src/port -I../../src/include > -D_GNU_SOURCE -c chklocale.c -o chklocale_srv.o > In file included from ../../src/include/postgres.h:48, > from chklocale.c:17: > ../../src/include/utils/elog.h:69:28: error: utils/errcodes.h: No such > file or directory > make[2]: *** [chklocale_srv.o] Error 1 > make[2]: Leaving directory `/home/postgres/head/src/port' > make[1]: *** [install-port-recurse] Error 2 > make[1]: Leaving directory `/home/postgres/head/src' > make: *** [install-src-recurse] Error 2 > > > I guess the following commit causes a problem. > > - > Avoid maintaining three separate copies of the error codes list. > > src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a > big chunk of errcodes.sgml are now automatically generated from a single > file, src/backend/utils/errcodes.txt. > - The build farm doesn't look too happy with it either, but of course it worked for me here. I guess there's a missing dependency somewhere. *goes off to look* -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Compilation failed
Hi, When I run "git pull" from the git master and "make", I encountered the following compilation error. gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -g -I../../src/port -I../../src/include -D_GNU_SOURCE -c chklocale.c -o chklocale_srv.o In file included from ../../src/include/postgres.h:48, from chklocale.c:17: ../../src/include/utils/elog.h:69:28: error: utils/errcodes.h: No such file or directory make[2]: *** [chklocale_srv.o] Error 1 make[2]: Leaving directory `/home/postgres/head/src/port' make[1]: *** [install-port-recurse] Error 2 make[1]: Leaving directory `/home/postgres/head/src' make: *** [install-src-recurse] Error 2 I guess the following commit causes a problem. - Avoid maintaining three separate copies of the error codes list. src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a big chunk of errcodes.sgml are now automatically generated from a single file, src/backend/utils/errcodes.txt. - Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compilation failed when --with-recode specified (patch)
Glad you are testing recode because I changed its token handling to use
the new unified token code used by pg_hba.conf and pg_ident.conf.
---
Oliver Elphick wrote:
-- Start of PGP signed section.
> Using this configuration:
> ./configure --enable-locale --enable-recode --enable-multibyte
> --enable-nls --with-pgport=9631 --with-CXX --with-perl --with-python
> --with-tcl --enable-odbc--with-unixodbc --with-openssl --with-pam
> --enable-syslog --enable-debug --enable-cassert --enable-depend
> --with-tkconfig=/usr/lib/tk8.3 --with-tclconfig=/usr/lib/tcl8.3
> --with-includes=/usr/include/tcl8.3
>
> current cvs would not compile. I found it necessary to make the
> following corrections:
>
> Index: src/backend/utils/init/miscinit.c
> ===
> RCS file: /projects/cvsroot/pgsql/src/backend/utils/init/miscinit.c,v
> retrieving revision 1.87
> diff -c -r1.87 miscinit.c
> *** src/backend/utils/init/miscinit.c 2002/04/27 21:24:34 1.87
> --- src/backend/utils/init/miscinit.c 2002/05/03 05:15:14
> ***
> *** 39,44
> --- 39,45
> #ifdef CYR_RECODE
> unsigned char RecodeForwTable[128];
> unsigned char RecodeBackTable[128];
> + static void GetCharSetByHost(char *TableName, int host, const char *DataDir);
> #endif
>
> ProcessingMode Mode = InitProcessing;
> ***
> *** 236,249
>
> #ifdef CYR_RECODE
>
> ! SetCharSet(void)
> {
> FILE *file;
> char *filename;
> char *map_file;
> charbuf[MAX_TOKEN];
> ! int i,
> ! c;
> unsigned char FromChar,
> ToChar;
> charChTable[MAX_TOKEN];
> --- 237,249
>
> #ifdef CYR_RECODE
>
> ! void SetCharSet(void)
> {
> FILE *file;
> char *filename;
> char *map_file;
> charbuf[MAX_TOKEN];
> ! int i;
> unsigned char FromChar,
> ToChar;
> charChTable[MAX_TOKEN];
> ***
> *** 289,295
> while (!feof(file) && buf[0])
> {
> next_token(file, buf, sizeof(buf));
> ! elog(LOG, "SetCharSet: unknown tag %s
>in file %s"
> buf, filename);
> }
> }
> --- 289,295
> while (!feof(file) && buf[0])
> {
> next_token(file, buf, sizeof(buf));
> ! elog(LOG, "SetCharSet: unknown tag %s
>in file %s",
> buf, filename);
> }
> }
> ***
> *** 445,451
> else if (strcasecmp(buf, "RecodeTable") == 0)
> key = KEY_TABLE;
> else
> ! elog(LOG, "GetCharSetByHost: unknown tag %s in file %s"
> buf, CHARSET_FILE);
>
> switch (key)
> --- 445,451
> else if (strcasecmp(buf, "RecodeTable") == 0)
> key = KEY_TABLE;
> else
> ! elog(LOG, "GetCharSetByHost: unknown tag %s in file
>%s",
> buf, CHARSET_FILE);
>
> switch (key)
> ***
> *** 501,507
> while (!feof(file) && buf[0])
> {
> next_token(file, buf, sizeof(buf));
> ! elog(LOG, "GetCharSetByHost: unknown tag %s in file %s"
> buf, CHARSET_FILE);
> }
> }
> --- 501,507
> while (!feof(file) && buf[0])
> {
> next_token(file, buf, sizeof(buf));
> ! elog(LOG, "GetCharSetByHost: unknown tag %s in file
>%s",
> buf, CHARSET_FILE);
> }
> }
> --
> Oliver Elphick[EMAIL PROTECTED]
> Isle of Wight http://www.lfix.co.uk/oliver
> GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C
>
> "Rejoice with them that do rejoice, and weep with them
> that weep."Romans 12:15
-- End of PGP section.
--
Bruce Momjian
Re: [HACKERS] Compilation failed when --with-recode specified (patch)
Oliver Elphick <[EMAIL PROTECTED]> writes: > current cvs would not compile. I found it necessary to make the > following corrections: A little software rot setting in there :-(. My compiler complained about even more stuff than yours did. Patch applied. regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
[HACKERS] Compilation failed when --with-recode specified (patch)
Using this configuration:
./configure --enable-locale --enable-recode --enable-multibyte
--enable-nls --with-pgport=9631 --with-CXX --with-perl --with-python
--with-tcl --enable-odbc--with-unixodbc --with-openssl --with-pam
--enable-syslog --enable-debug --enable-cassert --enable-depend
--with-tkconfig=/usr/lib/tk8.3 --with-tclconfig=/usr/lib/tcl8.3
--with-includes=/usr/include/tcl8.3
current cvs would not compile. I found it necessary to make the
following corrections:
Index: src/backend/utils/init/miscinit.c
===
RCS file: /projects/cvsroot/pgsql/src/backend/utils/init/miscinit.c,v
retrieving revision 1.87
diff -c -r1.87 miscinit.c
*** src/backend/utils/init/miscinit.c 2002/04/27 21:24:34 1.87
--- src/backend/utils/init/miscinit.c 2002/05/03 05:15:14
***
*** 39,44
--- 39,45
#ifdef CYR_RECODE
unsigned char RecodeForwTable[128];
unsigned char RecodeBackTable[128];
+ static void GetCharSetByHost(char *TableName, int host, const char *DataDir);
#endif
ProcessingMode Mode = InitProcessing;
***
*** 236,249
#ifdef CYR_RECODE
! SetCharSet(void)
{
FILE *file;
char *filename;
char *map_file;
charbuf[MAX_TOKEN];
! int i,
! c;
unsigned char FromChar,
ToChar;
charChTable[MAX_TOKEN];
--- 237,249
#ifdef CYR_RECODE
! void SetCharSet(void)
{
FILE *file;
char *filename;
char *map_file;
charbuf[MAX_TOKEN];
! int i;
unsigned char FromChar,
ToChar;
charChTable[MAX_TOKEN];
***
*** 289,295
while (!feof(file) && buf[0])
{
next_token(file, buf, sizeof(buf));
! elog(LOG, "SetCharSet: unknown tag %s
in file %s"
buf, filename);
}
}
--- 289,295
while (!feof(file) && buf[0])
{
next_token(file, buf, sizeof(buf));
! elog(LOG, "SetCharSet: unknown tag %s
in file %s",
buf, filename);
}
}
***
*** 445,451
else if (strcasecmp(buf, "RecodeTable") == 0)
key = KEY_TABLE;
else
! elog(LOG, "GetCharSetByHost: unknown tag %s in file %s"
buf, CHARSET_FILE);
switch (key)
--- 445,451
else if (strcasecmp(buf, "RecodeTable") == 0)
key = KEY_TABLE;
else
! elog(LOG, "GetCharSetByHost: unknown tag %s in file
%s",
buf, CHARSET_FILE);
switch (key)
***
*** 501,507
while (!feof(file) && buf[0])
{
next_token(file, buf, sizeof(buf));
! elog(LOG, "GetCharSetByHost: unknown tag %s in file %s"
buf, CHARSET_FILE);
}
}
--- 501,507
while (!feof(file) && buf[0])
{
next_token(file, buf, sizeof(buf));
! elog(LOG, "GetCharSetByHost: unknown tag %s in file
%s",
buf, CHARSET_FILE);
}
}
--
Oliver Elphick[EMAIL PROTECTED]
Isle of Wight http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C
"Rejoice with them that do rejoice, and weep with them
that weep."Romans 12:15
signature.asc
Description: This is a digitally signed message part
