Re: [HACKERS] Confusing comment in TransactionIdIsInProgress

2011-01-19 Thread Simon Riggs
On Tue, 2011-01-18 at 10:51 +0200, Heikki Linnakangas wrote: > On 18.01.2011 07:15, Jim Nasby wrote: > > Shouldn't the comment read "If first time through"? > > > > /* > > * If not first time through, get workspace to remember main XIDs in. We > > * malloc it permanently to avoid repe

Re: [HACKERS] Confusing comment in TransactionIdIsInProgress

2011-01-18 Thread Heikki Linnakangas
On 18.01.2011 07:15, Jim Nasby wrote: Shouldn't the comment read "If first time through"? /* * If not first time through, get workspace to remember main XIDs in. We * malloc it permanently to avoid repeated palloc/pfree overhead. */ if (xids == NULL)

[HACKERS] Confusing comment in TransactionIdIsInProgress

2011-01-17 Thread Jim Nasby
Shouldn't the comment read "If first time through"? /* * If not first time through, get workspace to remember main XIDs in. We * malloc it permanently to avoid repeated palloc/pfree overhead. */ if (xids == NULL) { ... xids = (Tran