Re: [HACKERS] Contrib PROGRAM problem

2013-01-20 Thread Craig Ringer
On 01/19/2013 05:42 AM, Boszormenyi Zoltan wrote: Hi, I want to test my lock_timeout code under Windows and I compiled the whole PG universe with the MinGW cross-compiler for 64-bit under Fedora 18. You're significantly better off compiling for native Windows if at all possible. Windows cloud

Re: [HACKERS] Contrib PROGRAM problem

2013-01-19 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: *sigh*. Don't post after midnight. Of course, this isn't relevant to a cross-compiling environment, where repeated invocations of make repeatedly build the executables. The question is whether we care enough about this case to fix it. I think we

[HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Boszormenyi Zoltan
Hi, I want to test my lock_timeout code under Windows and I compiled the whole PG universe with the MinGW cross-compiler for 64-bit under Fedora 18. The problem contrib directories where Makefile contains PROGRAM = ... The executables binaries are created without the .exe suffix. E.g.:

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Alvaro Herrera
Boszormenyi Zoltan wrote: I want to test my lock_timeout code under Windows and I compiled the whole PG universe with the MinGW cross-compiler for 64-bit under Fedora 18. The problem contrib directories where Makefile contains PROGRAM = ... The executables binaries are created

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Boszormenyi Zoltan
2013-01-18 22:52 keltezéssel, Alvaro Herrera írta: Boszormenyi Zoltan wrote: I want to test my lock_timeout code under Windows and I compiled the whole PG universe with the MinGW cross-compiler for 64-bit under Fedora 18. The problem contrib directories where Makefile contains PROGRAM =

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Andrew Dunstan
On 01/18/2013 05:19 PM, Boszormenyi Zoltan wrote: 2013-01-18 22:52 keltezéssel, Alvaro Herrera írta: Boszormenyi Zoltan wrote: I want to test my lock_timeout code under Windows and I compiled the whole PG universe with the MinGW cross-compiler for 64-bit under Fedora 18. The problem

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Boszormenyi Zoltan
2013-01-18 23:37 keltezéssel, Andrew Dunstan írta: On 01/18/2013 05:19 PM, Boszormenyi Zoltan wrote: 2013-01-18 22:52 keltezéssel, Alvaro Herrera írta: Boszormenyi Zoltan wrote: I want to test my lock_timeout code under Windows and I compiled the whole PG universe with the MinGW

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Andrew Dunstan
On 01/18/2013 05:45 PM, Boszormenyi Zoltan wrote: 2013-01-18 23:37 keltezéssel, Andrew Dunstan írta: On 01/18/2013 05:19 PM, Boszormenyi Zoltan wrote: 2013-01-18 22:52 keltezéssel, Alvaro Herrera írta: Boszormenyi Zoltan wrote: I want to test my lock_timeout code under Windows and I

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Andrew Dunstan
On 01/18/2013 07:03 PM, Andrew Dunstan wrote: It's not a good idea it seems. Because that's only half of what I suggested. This patch seems to do the right thing. It probably needs to be applied to all the live branches. cheers andrew diff --git a/src/makefiles/pgxs.mk

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: This patch seems to do the right thing. Hmm ... seems kinda grotty ... isn't there a cleaner way? It probably needs to be applied to all the live branches. Agreed on back-patching once we have the right thing, but I don't like this version too much.

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Andrew Dunstan
On 01/18/2013 11:42 PM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: This patch seems to do the right thing. Hmm ... seems kinda grotty ... isn't there a cleaner way? It probably needs to be applied to all the live branches. Agreed on back-patching once we have the right

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Peter Eisentraut
On Fri, 2013-01-18 at 17:37 -0500, Andrew Dunstan wrote: ifdef PROGRAM $(PROGRAM): $(OBJS) - $(CC) $(CFLAGS) $(OBJS) $(PG_LIBS) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@ + $(CC) $(CFLAGS) $(OBJS) $(PG_LIBS) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X) endif Wouldn't it

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Andrew Dunstan
On 01/18/2013 11:59 PM, Peter Eisentraut wrote: The above is the way it's done everywhere else in the source tree. I think the reason this works is that either make or the system call that make uses is aware of this naming issue somehow. Oh, hmm, all these years playing with this stuff and

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Boszormenyi Zoltan
2013-01-19 01:03 keltezéssel, Andrew Dunstan írta: On 01/18/2013 05:45 PM, Boszormenyi Zoltan wrote: 2013-01-18 23:37 keltezéssel, Andrew Dunstan írta: On 01/18/2013 05:19 PM, Boszormenyi Zoltan wrote: 2013-01-18 22:52 keltezéssel, Alvaro Herrera írta: Boszormenyi Zoltan wrote: I want

Re: [HACKERS] Contrib PROGRAM problem

2013-01-18 Thread Boszormenyi Zoltan
2013-01-19 02:03 keltezéssel, Andrew Dunstan írta: On 01/18/2013 07:03 PM, Andrew Dunstan wrote: It's not a good idea it seems. Because that's only half of what I suggested. This patch seems to do the right thing. It probably needs to be applied to all the live branches. cheers