Re: [HACKERS] DEALLOCATE IF EXISTS

2012-12-05 Thread Heikki Linnakangas
On 30.11.2012 12:05, Vik Reykja wrote: On Tue, Nov 27, 2012 at 3:15 PM, Heikki Linnakangas wrote: I fail to see the point of DEALLOCATE IF EXISTS. Do you have real use case for this, or was this just a case of adding IF EXISTS to all commands for the sake of completeness? Usually the client k

Re: [HACKERS] DEALLOCATE IF EXISTS

2012-11-30 Thread Vik Reykja
On Tue, Nov 27, 2012 at 3:15 PM, Heikki Linnakangas wrote: > I fail to see the point of DEALLOCATE IF EXISTS. Do you have real use case > for this, or was this just a case of adding IF EXISTS to all commands for > the sake of completeness? > > Usually the client knows what statements have been pr

Re: [HACKERS] DEALLOCATE IF EXISTS

2012-11-27 Thread Heikki Linnakangas
On 09.10.2012 17:44, Vik Reykja wrote: On Tue, Oct 9, 2012 at 4:09 PM, Tom Lane wrote: =?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= writes: Indeed, brackets was not correct, it's better now (I think), and correct some comments. Still wrong ... at the very least you missed copyfuncs/equalfuncs.

Re: [HACKERS] DEALLOCATE IF EXISTS

2012-11-20 Thread Marko Tiikkaja
On Tue, 09 Oct 2012 16:44:07 +0200, Vik Reykja wrote: I don't see Sébastien's message, but I made the same mistake in my patch. Another one is attached with copyfuncs and equalfuncs. I did a grep for DeallocateStmt and I don't believe I have missed anything else. The patch looks pretty straig

Re: [HACKERS] DEALLOCATE IF EXISTS

2012-11-09 Thread Vik Reykja
On Tue, Oct 9, 2012 at 4:44 PM, Vik Reykja wrote: > On Tue, Oct 9, 2012 at 4:09 PM, Tom Lane wrote: > >> =?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= writes: >> > Indeed, brackets was not correct, it's better now (I think), and correct >> > some comments. >> >> Still wrong ... at the very least you

Re: [HACKERS] DEALLOCATE IF EXISTS

2012-10-09 Thread Vik Reykja
On Tue, Oct 9, 2012 at 4:09 PM, Tom Lane wrote: > =?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= writes: > > Indeed, brackets was not correct, it's better now (I think), and correct > > some comments. > > Still wrong ... at the very least you missed copyfuncs/equalfuncs. > In general, when adding a fie