[HACKERS] Dead code as a result of plan cache invalidation?

2007-07-04 Thread Gregory Stark
Should this case at heaptuple.c:1606 be turned into an elog() now that we have plan cache invalidation? If it can't happen then it's probably better that we find out if it does happen rather than silently run the old plan and return nulls. /* * If the attribute's column has been

Re: [HACKERS] Dead code as a result of plan cache invalidation?

2007-07-04 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Should this case at heaptuple.c:1606 be turned into an elog() now that we have plan cache invalidation? No, I think it's good as-is. Reading the column as null is the correct behavior. regards, tom lane

Re: [HACKERS] Dead code as a result of plan cache invalidation?

2007-07-04 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: Gregory Stark [EMAIL PROTECTED] writes: Should this case at heaptuple.c:1606 be turned into an elog() now that we have plan cache invalidation? No, I think it's good as-is. Reading the column as null is the correct behavior. Isn't the correct

Re: [HACKERS] Dead code as a result of plan cache invalidation?

2007-07-04 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Let me put it another way, how would I write a test case to cover these lines of code and not receive an error from replanning? Hard to get to is not the same as dead code. An example is that third-party add-ons might re-use plans that are not completely