Hi all,
I noticed that the following structures are still defined in
gin_private.h but they are used nowhere since 2c03216d that has
reworked WAL format:
- ginxlogSplitEntry
- ginxlogSplitDataLeaf
- ginxlogSplitDataInternal
Attached is a trivial patch to remove them.
Regards,
--
Michael
diff --git a/src/include/access/gin_private.h b/src/include/access/gin_private.h
index bda7c28..9bb0ba4 100644
--- a/src/include/access/gin_private.h
+++ b/src/include/access/gin_private.h
@@ -511,34 +511,6 @@ typedef struct ginxlogSplit
#define GIN_INSERT_ISLEAF 0x02 /* .. */
#define GIN_SPLIT_ROOT 0x04 /* only for split records */
-typedef struct
-{
- OffsetNumber separator;
- OffsetNumber nitem;
-
- /* FOLLOWS: IndexTuples */
-} ginxlogSplitEntry;
-
-typedef struct
-{
- uint16 lsize;
- uint16 rsize;
- ItemPointerData lrightbound; /* new right bound of left page */
- ItemPointerData rrightbound; /* new right bound of right page */
-
- /* FOLLOWS: new compressed posting lists of left and right page */
- char newdata[1];
-} ginxlogSplitDataLeaf;
-
-typedef struct
-{
- OffsetNumber separator;
- OffsetNumber nitem;
- ItemPointerData rightbound;
-
- /* FOLLOWS: array of PostingItems */
-} ginxlogSplitDataInternal;
-
/*
* Vacuum simply WAL-logs the whole page, when anything is modified. This
* functionally identical heap_newpage records, but is kept separate for
diff --git a/src/tools/pgindent/typedefs.list b/src/tools/pgindent/typedefs.list
index cfd580c..ca7454f 100644
--- a/src/tools/pgindent/typedefs.list
+++ b/src/tools/pgindent/typedefs.list
@@ -2192,9 +2192,6 @@ ginxlogInsertEntry
ginxlogInsertListPage
ginxlogRecompressDataLeaf
ginxlogSplit
-ginxlogSplitDataInternal
-ginxlogSplitDataLeaf
-ginxlogSplitEntry
ginxlogUpdateMeta
ginxlogVacuumDataLeafPage
ginxlogVacuumPage
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
