Re: [HACKERS] Display oprcode and its volatility in \do+

2014-02-21 Thread Marti Raudsepp
On Thu, Jan 16, 2014 at 5:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: but adding volatility here seems like probably a waste of valuable terminal width. I think that the vast majority of operators have immutable or at worst stable underlying functions, so this doesn't seem like the first bit of

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-01-16 Thread Rushabh Lathia
Hi, I have reviewed you patch. -- Patch got applied cleanly (using patch -p1) -- Make Make install works fine -- make check looks good I done code-walk and it looks good. Also did some manual testing and haven't found any issue with the implementation. Even I personally felt the Function and

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-01-16 Thread Marko Tiikkaja
On 1/16/14 9:53 AM, Rushabh Lathia wrote: I have reviewed you patch. -- Patch got applied cleanly (using patch -p1) -- Make Make install works fine -- make check looks good I done code-walk and it looks good. Also did some manual testing and haven't found any issue with the implementation.

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-01-16 Thread Tom Lane
Marko Tiikkaja ma...@joh.to writes: On 1/16/14 9:53 AM, Rushabh Lathia wrote: Even I personally felt the Function and Volatility is nice to have info into \do+. FWIW, I'm on board with the idea of printing the oprcode, but adding volatility here seems like probably a waste of valuable terminal

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-01-16 Thread Marko Tiikkaja
On 1/16/14 4:22 PM, Tom Lane wrote: Marko Tiikkaja ma...@joh.to writes: On 1/16/14 9:53 AM, Rushabh Lathia wrote: Even I personally felt the Function and Volatility is nice to have info into \do+. FWIW, I'm on board with the idea of printing the oprcode, but adding volatility here seems like

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-01-16 Thread Tom Lane
Marko Tiikkaja ma...@joh.to writes: On 1/16/14 4:22 PM, Tom Lane wrote: FWIW, I'm on board with the idea of printing the oprcode, but adding volatility here seems like probably a waste of valuable terminal width. I think that the vast majority of operators have immutable or at worst stable

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-01-16 Thread Tom Lane
I wrote: Anybody else have an opinion? Given the lack of other votes, I pushed this without a volatility column, and with some other changes --- mostly, I kept the Description column last, because that's how all the other \d commands do it. regards, tom lane -- Sent

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-01-16 Thread Marko Tiikkaja
On 1/16/14, 9:32 PM, Tom Lane wrote: Given the lack of other votes, I pushed this without a volatility column, and with some other changes --- mostly, I kept the Description column last, because that's how all the other \d commands do it. Thanks! And looks like I missed the documentation as