Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread Peter Geoghegan
On 21 February 2012 20:30, Tom Lane wrote: > Peter Geoghegan writes: >> My pg_stat_statements normalisation patch actually extends the >> underlying hash_any() function to support 8 byte results, > > ... er, what?  That seems rather out of scope for that patch, > not to mention unnecessary. Well

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread k...@rice.edu
On Tue, Feb 21, 2012 at 12:14:03PM -0800, David E. Wheeler wrote: > On Feb 21, 2012, at 12:11 PM, Michael Glaesemann wrote: > > > And hashtext *has* changed across versions, which is why Peter Eisentraut > > published a version-independent hash function library: > > https://github.com/petere/pgv

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread Tom Lane
Peter Geoghegan writes: > My pg_stat_statements normalisation patch actually extends the > underlying hash_any() function to support 8 byte results, ... er, what? That seems rather out of scope for that patch, not to mention unnecessary. regards, tom lane -- Sent via p

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread David E. Wheeler
On Feb 21, 2012, at 12:14 PM, David E. Wheeler wrote: >> And hashtext *has* changed across versions, which is why Peter Eisentraut >> published a version-independent hash function library: >> https://github.com/petere/pgvihash > > Yes, Marko wrote one, too: > > https://github.com/markokr/pgha

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread David E. Wheeler
On Feb 21, 2012, at 12:11 PM, Michael Glaesemann wrote: > And hashtext *has* changed across versions, which is why Peter Eisentraut > published a version-independent hash function library: > https://github.com/petere/pgvihash Yes, Marko wrote one, too: https://github.com/markokr/pghashlib B

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread Peter Geoghegan
On 21 February 2012 20:01, Tom Lane wrote: > "David E. Wheeler" writes: >> Is there a reason that hashtext() and friends are not documented? > > Yes.  They are internal functions that exist for the convenience of the > system, not for users.  We've discussed this before, and decided that > we don

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread Michael Glaesemann
On Feb 21, 2012, at 15:01, Tom Lane wrote: > "David E. Wheeler" writes: >> Is there a reason that hashtext() and friends are not documented? > > Yes. They are internal functions that exist for the convenience of the > system, not for users. We've discussed this before, and decided that > we d

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread Tom Lane
"David E. Wheeler" writes: > Is there a reason that hashtext() and friends are not documented? Yes. They are internal functions that exist for the convenience of the system, not for users. We've discussed this before, and decided that we don't want people to rely on them continuing to have exac

[HACKERS] Document hashtext() and Friends?

2012-02-21 Thread David E. Wheeler
Hackers, Is there a reason that hashtext() and friends are not documented? Given that they’re likely to be used more and more for partitioning and sharding, I think it would be useful to do so, starting with something like this. Comments? *** a/doc/src/sgml/func.sgml --- b/doc/src/sgml/func.sgm