Re: [HACKERS] Does parallel make require guards against duplicate actions?

2010-01-05 Thread Peter Eisentraut
On mån, 2010-01-04 at 21:58 -0500, Tom Lane wrote: The old Gen_fmgrtab.sh script used temporary file names that included its process PID. It had this comment about that: # We use the temporary files to avoid problems with concurrent runs # (which can happen during parallel make). The new

Re: [HACKERS] Does parallel make require guards against duplicate actions?

2010-01-05 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On mån, 2010-01-04 at 21:58 -0500, Tom Lane wrote: The new implementation uses temp files that just have .tmp appended to the target file name. If there is a risk that make -j will run the same action twice in parallel, this isn't good enough. While

[HACKERS] Does parallel make require guards against duplicate actions?

2010-01-04 Thread Tom Lane
The old Gen_fmgrtab.sh script used temporary file names that included its process PID. It had this comment about that: # We use the temporary files to avoid problems with concurrent runs # (which can happen during parallel make). The new implementation uses temp files that just have .tmp

Re: [HACKERS] Does parallel make require guards against duplicate actions?

2010-01-04 Thread John Naylor
FWIW, the old make rule was fmgroids.h fmgrtab.c: (deps) which is now fmgroids.h: fmgrtab.c ; fmgrtab.c: (deps) I was going by this comment in parser/Makefile: # There is no correct way to write a rule that generates two files. # Rules with two targets don't have that meaning, they are