Re: [HACKERS] Draft release notes up for review

[Alvaro Herrera]

Tom Lane wrote:
> Jonathan Katz  writes:
> > I see this one
> > > Fix potential data corruption when freezing a tuple whose XMAX is a 
> > multixact with exactly one still-interesting member
> > But I’m unsure how prevalent it is and if it should be highlighted.
> 
> I'm not sure about that either.  I do not think anyone did the legwork
> to determine the exact consequences of that bug, or the probability of
> someone hitting it in the field.  But I think the latter must be really
> low, because we haven't heard any field reports that seem to match up.

My assessment is that that bug is extremely hard to hit.  The main
conditions are, according to FreezeMultiXactId, that
1) the tuple must have a multixact xmax; and
2) the update xid must be newer than the cutoff freeze xid;
3) the multixact itself must be older than the cutoff freeze multi.

so the multixact counter needs to go faster than the xid counter (in
terms of who gets past the freeze age first), and a vacuum freeze must
be attempted on that tuple before the update xid becomes freezable.

The consequence is that the infomask, instead of ending up as

 frz->t_infomask = tuple->t_infomask;
 frz->t_infomask &= ~HEAP_XMAX_BITS;
 |= HEAP_XMAX_COMMITTED;
 tuple->t_infomask = frz->t_infomask;

is instead

 frz->t_infomask = tuple->t_infomask;
 frz->t_infomask &= ~HEAP_XMAX_BITS;
 &= HEAP_XMAX_COMMITTED;
 tuple->t_infomask = frz->t_infomask;

so any bit other than XMAX_COMMITTED is turned off -- which could be
pretty bad for HEAP_HASNULL, etc.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Jonathan Katz]

> On Aug 5, 2017, at 5:37 PM, Tom Lane  wrote:
> 
> Jonathan Katz  writes:
>> I see this one
>>  > Fix potential data corruption when freezing a tuple whose XMAX is a 
>> multixact with exactly one still-interesting member
>> But I’m unsure how prevalent it is and if it should be highlighted.
> 
> I'm not sure about that either.  I do not think anyone did the legwork
> to determine the exact consequences of that bug, or the probability of
> someone hitting it in the field.  But I think the latter must be really
> low, because we haven't heard any field reports that seem to match up.

OK, thanks for the clarification.  I will follow-up once I have the draft ready 
for technical review.

Thanks,

Jonathan



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Tom Lane]

Andres Freund  writes:
> I just pushed a 9.4 specific bugfix. Do you want me to fix up the
> release notes after you backpatch the minor release to 9.4, or what's
> the best process?

No sweat, I'll incorporate it when I do the further-back-branch
notes tomorrow.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Andres Freund]

Hi Tom,

On 2017-08-04 18:41:12 -0400, Tom Lane wrote:
> I've committed the first-draft release notes for 9.6.4 at
> https://git.postgresql.org/pg/commitdiff/03378c4da598840b0520a53580dd7713c95f21c8

I just pushed a 9.4 specific bugfix. Do you want me to fix up the
release notes after you backpatch the minor release to 9.4, or what's
the best process?

Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Tom Lane]

Jonathan Katz  writes:
> I see this one
>   > Fix potential data corruption when freezing a tuple whose XMAX is a 
> multixact with exactly one still-interesting member
> But I’m unsure how prevalent it is and if it should be highlighted.

I'm not sure about that either.  I do not think anyone did the legwork
to determine the exact consequences of that bug, or the probability of
someone hitting it in the field.  But I think the latter must be really
low, because we haven't heard any field reports that seem to match up.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Jonathan Katz]

Hi Tom,

> On Aug 4, 2017, at 6:41 PM, Tom Lane  wrote:
> 
> I've committed the first-draft release notes for 9.6.4 at
> https://git.postgresql.org/pg/commitdiff/03378c4da598840b0520a53580dd7713c95f21c8
> 
> (If you prefer to read nicely-marked-up copy, they should be up at
> https://www.postgresql.org/docs/devel/static/release-9-6-4.html
> in a couple hours from now.)

Thank you for putting these together.  For the press release, are there any 
features you (or anyone on -hackers) do you see any fixes you would like to 
highlight?

I see this one

> Fix potential data corruption when freezing a tuple whose XMAX is a 
multixact with exactly one still-interesting member

But I’m unsure how prevalent it is and if it should be highlighted.

Thanks,

Jonathan



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Draft release notes up for review

[Tom Lane]

I've committed the first-draft release notes for 9.6.4 at
https://git.postgresql.org/pg/commitdiff/03378c4da598840b0520a53580dd7713c95f21c8

(If you prefer to read nicely-marked-up copy, they should be up at
https://www.postgresql.org/docs/devel/static/release-9-6-4.html
in a couple hours from now.)

Please review.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Draft release notes up for review

[Tom Lane]

I've committed first-draft release notes for next week's back-branch
releases.  As usual, I've made a section for 9.4.2 that currently
includes items for all branches; I'll subdivide the items tomorrow.
If you wish to review, please send comments in the next 18 hours or so.

Patch is up now at
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=0563b4c0c3b7cc2323cfb63e11d723764e2d5f7d
and the formatted results should be visible on the devel docs build at
http://www.postgresql.org/docs/devel/static/
in a couple of hours.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Tom Lane]

I wrote:
 First draft of release notes for the upcoming minor releases is committed
 at
 http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=77e9125e847adf76e9466814781957c0f32d8554
 It should be visible on the documentation website after guaibasaurus does
 its next buildfarm run, a couple hours from now.

BTW, that's up now at

http://www.postgresql.org/docs/devel/static/release-9-4-1.html

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Draft release notes up for review

[Tom Lane]

First draft of release notes for the upcoming minor releases is committed
at

http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=77e9125e847adf76e9466814781957c0f32d8554

It should be visible on the documentation website after guaibasaurus does
its next buildfarm run, a couple hours from now.

Please let me know of any corrections ASAP.

Note that I've been fairly ruthless about removing items altogether if
they were unlikely to have clear user-visible impact, because the notes
were eye-glazingly long already.  Please mention it if you see any
remaining items that we could dispense with ... or if you think I
underestimated the significance of anything that got dropped.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Tom Lane]

Amit Langote amitlangot...@gmail.com writes:
 Perhaps the following two missed?

 http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=deadbf4f3324f7b2826cac60dd212dfa1b0084ec

 http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=cd63c57e5cbfc16239aa6837f8b7043a721cdd28

Hm?  Those are both included ... right next to each other in fact,
starting at about line 275 in release-9.4.sgml as it currently stands.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Noah Misch]

On Wed, Feb 19, 2014 at 08:29:38PM +0200, Marti Raudsepp wrote:
 On Sun, Feb 16, 2014 at 10:41 PM, Tom Lane t...@sss.pgh.pa.us wrote:
  Shore up GRANT ... WITH ADMIN OPTION restrictions (Noah Misch)
 
 I'm not familiar with the phrase Shore up, I think it should use
 more precise language: are the privilege checks getting more strict or
 less strict?

Here, shore up essentially means fix.  The checks are now stricter.  I
will look for more-specific words next time, but I think the paragraph
following that headline illustrates that we fixed overly-permissive checks.

-- 
Noah Misch
EnterpriseDB http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Marti Raudsepp]

On Sun, Feb 16, 2014 at 10:41 PM, Tom Lane t...@sss.pgh.pa.us wrote:
 Any comments before I start transposing them into the back branches?

Sorry I'm late.

 Shore up GRANT ... WITH ADMIN OPTION restrictions (Noah Misch)

I'm not familiar with the phrase Shore up, I think it should use
more precise language: are the privilege checks getting more strict or
less strict?



Wow, there are quite a lot of items this time. Have you considered
grouping the items by their impact, for example security/data
corruption/crash/correctness/other? I think that would make it easier
for readers to find items they're interested in. Most changes seem
pretty straightforward to categorize; there are always outliers, but
even if a few items are miscategorized, that's an improvement over
what we have now. Of course someone has to  be willing to do that work.

If this warrants more discussion, I can draft out a proposal in a new topic.

Regards,
Marti


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Alvaro Herrera]

Josh Berkus wrote:
 On 02/16/2014 03:41 PM, Tom Lane wrote:
  Draft release notes for 9.3.3 are committed and can be read at
  http://www.postgresql.org/docs/devel/static/release-9-3-3.html
  Any comments before I start transposing them into the back branches?
 
 Major:
 
 Do we have an explantion of what a multixact is, anywhere, so that we
 can link it?

Is this enough?
http://www.postgresql.org/docs/devel/static/routine-vacuuming.html#VACUUM-FOR-MULTIXACT-WRAPAROUND


-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Tom Lane]

Josh Berkus j...@agliodbs.com writes:
 On 02/16/2014 03:41 PM, Tom Lane wrote:
 Draft release notes for 9.3.3 are committed and can be read at
 http://www.postgresql.org/docs/devel/static/release-9-3-3.html
 Any comments before I start transposing them into the back branches?

 Major:

 Do we have an explantion of what a multixact is, anywhere, so that we
 can link it?

Fixed.  I did a bit of wordsmithing on the text Alvaro pointed to, too.

 Minor:

 ECPG or ecpg?  Pick one or the other.

AFAICS, ecpg is the vast majority case in the release notes, so
that's what I've used.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Draft release notes up for review

[Tom Lane]

Draft release notes for 9.3.3 are committed and can be read at
http://www.postgresql.org/docs/devel/static/release-9-3-3.html
Any comments before I start transposing them into the back branches?

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Josh Berkus]

On 02/16/2014 03:41 PM, Tom Lane wrote:
 Draft release notes for 9.3.3 are committed and can be read at
 http://www.postgresql.org/docs/devel/static/release-9-3-3.html
 Any comments before I start transposing them into the back branches?

Major:

Do we have an explantion of what a multixact is, anywhere, so that we
can link it?

Minor:

ECPG or ecpg?  Pick one or the other.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Boszormenyi Zoltan]

2013-03-29 02:46 keltezéssel, Tom Lane írta:

Since there has been some, um, grumbling about the quality of the
release notes of late, I've prepared draft notes for next week's
releases, covering commits through today.  These are now committed
into the master branch for review, and should show up at
http://www.postgresql.org/docs/devel/static/
after guaibasaurus' next buildfarm run, about three hours from now.

Please comment if you find anything that could be improved.


The sgml converter seems to choke on the UTF-8 characters that my name contains:

Add configuration variable lock_timeout to limit lock wait duration (Zoltán 
Böszörményi)

I don't mind if my name is written without the accented characters like in the 
other entry:

Have pg_basebackup --write-recovery-conf output a minimal recovery.conf (Zoltan 
Boszormenyi, Magnus Hagander)


Alternatively the sgml tool can be taught to emit proper HTML accented 
characters
or my name can be written as Zoltaacute;n Bouml;szouml;rmeacute;nyi

Best regards,
Zoltán Böszörményi



regards, tom lane





--
--
Zoltán Böszörményi
Cybertec Schönig  Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
 http://www.postgresql.at/



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Boszormenyi Zoltan]

2013-04-21 08:28 keltezéssel, Boszormenyi Zoltan írta:

2013-03-29 02:46 keltezéssel, Tom Lane írta:

Since there has been some, um, grumbling about the quality of the
release notes of late, I've prepared draft notes for next week's
releases, covering commits through today.  These are now committed
into the master branch for review, and should show up at
http://www.postgresql.org/docs/devel/static/
after guaibasaurus' next buildfarm run, about three hours from now.

Please comment if you find anything that could be improved.


The sgml converter seems to choke on the UTF-8 characters that my name contains:

Add configuration variable lock_timeout to limit lock wait duration (Zoltán 
Böszörményi)


I don't mind if my name is written without the accented characters like in the 
other entry:

Have pg_basebackup --write-recovery-conf output a minimal recovery.conf (Zoltan 
Boszormenyi, Magnus Hagander)


Alternatively the sgml tool can be taught to emit proper HTML accented 
characters
or my name can be written as Zoltaacute;n Bouml;szouml;rmeacute;nyi


doc/src/sgml/release.sgml suggest using the last one but when I looked at
release-9.3, I saw (AlvaroAacute;lvaro Herrera) in the webpage several times
where the sgml contains (Aacute;lvaro Herrera), so it's not bulletproof 
either.



Best regards,
Zoltán Böszörményi



regards, tom lane








--
--
Zoltán Böszörményi
Cybertec Schönig  Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
 http://www.postgresql.at/



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Bruce Momjian]

On Sun, Apr 21, 2013 at 09:25:39AM +0200, Boszormenyi Zoltan wrote:
 doc/src/sgml/release.sgml suggest using the last one but when I looked at
 release-9.3, I saw (AlvaroAacute;lvaro Herrera) in the webpage several times
 where the sgml contains (Aacute;lvaro Herrera), so it's not bulletproof 
 either.

Yes, fixed in commit 8 hours ago.  Thanks.  '' expanded in my regex.  :-(

-- 
  Bruce Momjian  br...@momjian.ushttp://momjian.us
  EnterpriseDB http://enterprisedb.com

  + It's impossible for everything to be true. +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Bruce Momjian]

On Sun, Apr 21, 2013 at 08:28:22AM +0200, Boszormenyi Zoltan wrote:
 2013-03-29 02:46 keltezéssel, Tom Lane írta:
 Since there has been some, um, grumbling about the quality of the
 release notes of late, I've prepared draft notes for next week's
 releases, covering commits through today.  These are now committed
 into the master branch for review, and should show up at
 http://www.postgresql.org/docs/devel/static/
 after guaibasaurus' next buildfarm run, about three hours from now.
 
 Please comment if you find anything that could be improved.
 
 The sgml converter seems to choke on the UTF-8 characters that my name 
 contains:
 
 Add configuration variable lock_timeout to limit lock wait duration (Zoltán 
 Böszörményi)
 
 I don't mind if my name is written without the accented characters like in 
 the other entry:
 
 Have pg_basebackup --write-recovery-conf output a minimal
 recovery.conf (Zoltan Boszormenyi, Magnus Hagander)
 
 Alternatively the sgml tool can be taught to emit proper HTML accented 
 characters
 or my name can be written as Zoltaacute;n Bouml;szouml;rmeacute;nyi

I have applied your patch to use entities.

-- 
  Bruce Momjian  br...@momjian.ushttp://momjian.us
  EnterpriseDB http://enterprisedb.com

  + It's impossible for everything to be true. +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Draft release notes up for review

[Tom Lane]

Since there has been some, um, grumbling about the quality of the
release notes of late, I've prepared draft notes for next week's
releases, covering commits through today.  These are now committed
into the master branch for review, and should show up at
http://www.postgresql.org/docs/devel/static/
after guaibasaurus' next buildfarm run, about three hours from now.

Please comment if you find anything that could be improved.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes up for review

[Alvaro Herrera]

Tom Lane wrote:
 Since there has been some, um, grumbling about the quality of the
 release notes of late, I've prepared draft notes for next week's
 releases, covering commits through today.  These are now committed
 into the master branch for review, and should show up at
 http://www.postgresql.org/docs/devel/static/
 after guaibasaurus' next buildfarm run, about three hours from now.

I prodded it a bit -- it's up now.

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers