Re: [HACKERS] Dropping PL language retains support functions

2012-03-06 Thread Bruce Momjian
On Mon, Mar 05, 2012 at 11:38:33PM -0500, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: By doing a DROP CASCADE on plpython2, you drop the user functions, but not the support functions. Well, yeah. The language depends on the support functions, not the other way around. This

Re: [HACKERS] Dropping PL language retains support functions

2012-03-06 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Mon, Mar 05, 2012 at 11:38:33PM -0500, Tom Lane wrote: Well, yeah. The language depends on the support functions, not the other way around. Well, if CREATE LANGUAGE created those functions, it seems logical that DROP FUNCTION removes them. Why is

Re: [HACKERS] Dropping PL language retains support functions

2012-03-06 Thread Bruce Momjian
On Tue, Mar 06, 2012 at 10:38:31AM -0500, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Mon, Mar 05, 2012 at 11:38:33PM -0500, Tom Lane wrote: Well, yeah. The language depends on the support functions, not the other way around. Well, if CREATE LANGUAGE created those

Re: [HACKERS] Dropping PL language retains support functions

2012-03-06 Thread Peter Eisentraut
On mån, 2012-03-05 at 19:37 -0500, Bruce Momjian wrote: The exact case is that the user was using plpython2u in PG 9.0, but the PG 9.1 one-click installer only supplies plpython3u. That seems like a pretty stupid choice to me, if it's true. That doesn't address your issue, but users shouldn't

Re: [HACKERS] Dropping PL language retains support functions

2012-03-06 Thread Robert Haas
On Tue, Mar 6, 2012 at 3:28 PM, Peter Eisentraut pete...@gmx.net wrote: On mån, 2012-03-05 at 19:37 -0500, Bruce Momjian wrote: The exact case is that the user was using plpython2u in PG 9.0, but the PG 9.1 one-click installer only supplies plpython3u. That seems like a pretty stupid choice

Re: [HACKERS] Dropping PL language retains support functions

2012-03-06 Thread Peter Eisentraut
On tis, 2012-03-06 at 16:15 -0500, Robert Haas wrote: On Tue, Mar 6, 2012 at 3:28 PM, Peter Eisentraut pete...@gmx.net wrote: On mån, 2012-03-05 at 19:37 -0500, Bruce Momjian wrote: The exact case is that the user was using plpython2u in PG 9.0, but the PG 9.1 one-click installer only

[HACKERS] Dropping PL language retains support functions

2012-03-05 Thread Bruce Momjian
I have a report related to pg_upgrade where the user states that dropping a PL language retains the PL support functions, and retains the dependency on the PL library, which causes pg_upgrade to complain. The exact case is that the user was using plpython2u in PG 9.0, but the PG 9.1 one-click

Re: [HACKERS] Dropping PL language retains support functions

2012-03-05 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: By doing a DROP CASCADE on plpython2, you drop the user functions, but not the support functions. Well, yeah. The language depends on the support functions, not the other way around. This certainly looks like a bug. Should I work on a patch? It's not