Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-26 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Now you might suggest that the function itself is redundant with the information given in the FunctionScan node line and so we need only show the argument list. Unfortunately there are cases where this fails; in particular, the named function could have

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-25 Thread Dimitri Fontaine
Argument List? -- dim Le 24 août 2010 à 18:06, Tom Lane t...@sss.pgh.pa.us a écrit : I wrote: Robert Haas robertmh...@gmail.com writes: If you try to put all that on the same line, I think it might get awkwardly long. Perhaps something like: Function Scan on function_name Expression:

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-25 Thread Tom Lane
Dimitri Fontaine dfonta...@hi-media.com writes: Argument List? Well, as shown in the example I posted, it's not just the argument list but the whole call: Function Call: unnest(ARRAY[ROW(('1.2.2'::text)::semver, '='::text, ('1.2.2'::text)::semver), ROW('1.2.23', '=', '1.2.23')]) Now you

[HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Tom Lane
So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report. Seems like this would be a good thing to print. Should it appear always, or just with VERBOSE, or ??? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread David Fetter
On Tue, Aug 24, 2010 at 10:40:30AM -0400, Tom Lane wrote: So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report. Seems like this would be a good thing to print. Should it appear always, or just with VERBOSE, or ??? +1 for always. Cheers, David. -- David Fetter

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Robert Haas
On Tue, Aug 24, 2010 at 10:40 AM, Tom Lane t...@sss.pgh.pa.us wrote: So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report.  Seems like this would be a good thing to print.  Should it appear always, or just with VERBOSE, or ??? I think showing it always is reasonable. I'd

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Robert Haas
On Tue, Aug 24, 2010 at 10:56 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Aug 24, 2010 at 10:40 AM, Tom Lane t...@sss.pgh.pa.us wrote: So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report.  Seems like this would be a good thing to print.  Should it appear always,

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Aug 24, 2010 at 10:56 AM, Robert Haas robertmh...@gmail.com wrote: I think showing it always is reasonable.  I'd like to see it printed in a form such that casting to regproc will succeed. On second thought, that second sentence may not make

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Robert Haas
On Tue, Aug 24, 2010 at 11:06 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Aug 24, 2010 at 10:56 AM, Robert Haas robertmh...@gmail.com wrote: I think showing it always is reasonable.  I'd like to see it printed in a form such that casting to regproc

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Andres Freund
Hi, On Tuesday 24 August 2010 16:40:30 Tom Lane wrote: So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report. Seems like this would be a good thing to print. Should it appear always, or just with VERBOSE, or ??? I vote for only showing it with verbose - not that its a new

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: If you try to put all that on the same line, I think it might get awkwardly long. Perhaps something like: Function Scan on function_name Expression: function_name(function_arg1, function_arg2, ...) Yeah, that's what I had in mind, but I'm still

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On Tuesday 24 August 2010 16:40:30 Tom Lane wrote: So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report. Seems like this would be a good thing to print. Should it appear always, or just with VERBOSE, or ??? I vote for only

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Andres Freund
On Tuesday 24 August 2010 17:36:50 Tom Lane wrote: Andres Freund and...@anarazel.de writes: On Tuesday 24 August 2010 16:40:30 Tom Lane wrote: So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report. Seems like this would be a good thing to print. Should it appear

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar ago 24 11:36:50 -0400 2010: Andres Freund and...@anarazel.de writes: On Tuesday 24 August 2010 16:40:30 Tom Lane wrote: So I got annoyed by $SUBJECT just now while chasing Wheeler's bug report. Seems like this would be a good thing to print. Should

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Tom Lane
I wrote: Robert Haas robertmh...@gmail.com writes: If you try to put all that on the same line, I think it might get awkwardly long. Perhaps something like: Function Scan on function_name Expression: function_name(function_arg1, function_arg2, ...) Yeah, that's what I had in mind, but I'm

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread David Fetter
On Tue, Aug 24, 2010 at 12:06:34PM -0400, Tom Lane wrote: I wrote: Robert Haas robertmh...@gmail.com writes: If you try to put all that on the same line, I think it might get awkwardly long. Perhaps something like: Function Scan on function_name Expression:

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Greg Stark
On Tue, Aug 24, 2010 at 5:06 PM, Tom Lane t...@sss.pgh.pa.us wrote:  Function Scan on pg_catalog.unnest f  (cost=0.00..1.50 rows=100 width=96)   Output: (((lv)::text || op) || (rv)::text)   Function Call: unnest(ARRAY[ROW(('1.2.2'::text)::semver, '='::text, ('1.2.2'::text)::semver),

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: On Tue, Aug 24, 2010 at 5:06 PM, Tom Lane t...@sss.pgh.pa.us wrote:  Function Scan on pg_catalog.unnest f  (cost=0.00..1.50 rows=100 width=96)   Output: (((lv)::text || op) || (rv)::text)   Function Call: unnest(ARRAY[ROW(('1.2.2'::text)::semver, '='::text,

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Robert Haas
On Tue, Aug 24, 2010 at 1:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Greg Stark gsst...@mit.edu writes: On Tue, Aug 24, 2010 at 5:06 PM, Tom Lane t...@sss.pgh.pa.us wrote:  Function Scan on pg_catalog.unnest f  (cost=0.00..1.50 rows=100 width=96)   Output: (((lv)::text || op) || (rv)::text)  

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread David E. Wheeler
On Aug 24, 2010, at 10:21 AM, Tom Lane wrote: This may be the ultimate bike-shed but Wouldn't this be clearer the other way around? I generally think input comes first and then output. The order was bothering me a bit too, but there's a generic decision in there that the tlist is shown

Re: [HACKERS] EXPLAIN doesn't show the actual function expression for FunctionScan

2010-08-24 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Aug 24, 2010, at 10:21 AM, Tom Lane wrote: The order was bothering me a bit too, but there's a generic decision in there that the tlist is shown before any node-type-specific items. Not sure that we want to move it to the bottom for all of them.