Robert Haas wrote:
Sure, the logfile will be filled with mixed encoding strings,
that could happen in logfile and syslog on non-win32 platforms.
I think UTF8 is better than UTF16 for logfile encoding because
there are some text editors that do not support wide characters.
At any rate,
2009/10/13 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Magnus Hagander mag...@hagander.net wrote:
One other question - you note that WriteConsoleW() could fail if
stderr is redirected. Are you saying that it will always fail when
stderr is redirected, or only sometimes? If ony
On Mon, Oct 12, 2009 at 9:13 PM, Itagaki Takahiro
itagaki.takah...@oss.ntt.co.jp wrote:
Magnus Hagander mag...@hagander.net wrote:
One other question - you note that WriteConsoleW() could fail if
stderr is redirected. Are you saying that it will always fail when
stderr is redirected, or only
Magnus Hagander mag...@hagander.net wrote:
One other question - you note that WriteConsoleW() could fail if
stderr is redirected. Are you saying that it will always fail when
stderr is redirected, or only sometimes? If ony sometimes, do you know
under which conditions it happens?
It will
Magnus Hagander mag...@hagander.net writes:
2009/10/7 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Also I added the following error checks before calling pgwin32_toUTF16()
(errordata_stack_depth ERRORDATA_STACK_SIZE - 1)
to avoid recursive errors, but I'm not sure it is really
2009/10/7 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Magnus Hagander mag...@hagander.net wrote:
Per your own comments earlier, and in the code, what will happen if
pg_do_encoding_conversion() calls ereport()? Didn't you say we need a
non-throwing version of it?
We are hard to use
2009/9/15 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote:
Can't we use MultiByteToWideChar() to convert directly to the required
encoding, avoiding the double conversion?
Here is an updated version of the patch.
I use direct
Magnus Hagander mag...@hagander.net wrote:
First of all, the change to port/open.c seems to be unrelated to the
rest, and should be a separate patch, correct? I'm sure there's a
usecase for it, but it's not actually included in the patches
description, so I assume this was a mistake?
It
On Tue, 2009-09-15 at 12:49 +0900, Itagaki Takahiro wrote:
Here is an updated version of the patch.
This is a review of the Eventlog encoding on Windows patch:
http://archives.postgresql.org/message-id/20090915123243.9c59.52131...@oss.ntt.co.jp
Purpose Format
This patch is
Itagaki Takahiro wrote:
We can choose different encodings from platform-dependent one
for database, but postgres writes serverlogs in the database encoding.
As the result, serverlogs are filled with broken characters.
The problem could occur on all platforms, however, there is a solution
Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote:
Can't we use MultiByteToWideChar() to convert directly to the required
encoding, avoiding the double conversion?
Here is an updated version of the patch.
I use direct conversion in pgwin32_toUTF16() if a corresponding codepage
is
We can choose different encodings from platform-dependent one
for database, but postgres writes serverlogs in the database encoding.
As the result, serverlogs are filled with broken characters.
The problem could occur on all platforms, however, there is a solution
for win32. Since Windows
12 matches
Mail list logo
