Re: [HACKERS] EvalPlanQual() doesn't follow LockTuple() pattern

2016-11-30 Thread Robert Haas
On Tue, Nov 29, 2016 at 6:26 AM, Simon Riggs wrote: > src/backend/access/heap/README.tuplock says we do this... > > LockTuple() > XactLockTableWait() > mark tuple as locked by me > UnlockTuple() > > only problem is we don't... because EvalPlanQualFetch() does this > > XactLockTableWait() > LockTup

[HACKERS] EvalPlanQual() doesn't follow LockTuple() pattern

2016-11-29 Thread Simon Riggs
src/backend/access/heap/README.tuplock says we do this... LockTuple() XactLockTableWait() mark tuple as locked by me UnlockTuple() only problem is we don't... because EvalPlanQualFetch() does this XactLockTableWait() LockTuple() If README.tuplock's reasons for the stated lock order is correct t