Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-08 Thread Michael Paquier
On Thu, Nov 9, 2017 at 1:03 AM, Peter Eisentraut wrote: > On 11/7/17 19:58, Michael Paquier wrote: >> On Wed, Nov 8, 2017 at 9:50 AM, Haribabu Kommi >> wrote: >>> Thanks for the correction. I was not much aware of SGML markup usage.

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-08 Thread Peter Eisentraut
On 11/7/17 19:58, Michael Paquier wrote: > On Wed, Nov 8, 2017 at 9:50 AM, Haribabu Kommi > wrote: >> Thanks for the correction. I was not much aware of SGML markup usage. >> While building the documentation, it raises an warning message of "empty >> end-tag". >> So I

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Michael Paquier
On Wed, Nov 8, 2017 at 9:50 AM, Haribabu Kommi wrote: > Thanks for the correction. I was not much aware of SGML markup usage. > While building the documentation, it raises an warning message of "empty > end-tag". > So I just added the end tag. Attached the update patch

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Haribabu Kommi
On Wed, Nov 8, 2017 at 11:11 AM, Michael Paquier wrote: > On Wed, Nov 8, 2017 at 9:04 AM, Haribabu Kommi > wrote: > > The commit 98267e missed to check the empty SGML tag, attached patch > > fixes the same. > > > > -

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Michael Paquier
On Wed, Nov 8, 2017 at 9:04 AM, Haribabu Kommi wrote: > The commit 98267e missed to check the empty SGML tag, attached patch > fixes the same. - pg_internal.init (found in multiple directories) + pg_internal.init (found in multiple

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Haribabu Kommi
On Wed, Nov 8, 2017 at 3:03 AM, Simon Riggs wrote: > On 5 November 2017 at 11:55, Magnus Hagander wrote: > > On Sat, Nov 4, 2017 at 4:04 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> > >> On Fri, Nov 3, 2017 at 4:04 PM, Petr

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Michael Paquier
On Wed, Nov 8, 2017 at 1:42 AM, David Steele wrote: > On 11/7/17 11:03 AM, Simon Riggs wrote: >> On 5 November 2017 at 11:55, Magnus Hagander wrote: >>> >>> So +1 for documenting the difference in how these are handled, as this is >>> important to know

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread David Steele
On 11/7/17 11:03 AM, Simon Riggs wrote: > On 5 November 2017 at 11:55, Magnus Hagander wrote: >> >> So +1 for documenting the difference in how these are handled, as this is >> important to know for somebody writing an external tool for it. > > Changes made, moving to commit

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread Simon Riggs
On 5 November 2017 at 11:55, Magnus Hagander wrote: > On Sat, Nov 4, 2017 at 4:04 AM, Michael Paquier > wrote: >> >> On Fri, Nov 3, 2017 at 4:04 PM, Petr Jelinek >> wrote: >> > Not specific problem to this patch, but

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-05 Thread Magnus Hagander
On Sat, Nov 4, 2017 at 4:04 AM, Michael Paquier wrote: > On Fri, Nov 3, 2017 at 4:04 PM, Petr Jelinek > wrote: > > Not specific problem to this patch, but I wonder if it should be made > > more clear that those files (there are couple

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-03 Thread Michael Paquier
On Fri, Nov 3, 2017 at 4:04 PM, Petr Jelinek wrote: > Not specific problem to this patch, but I wonder if it should be made > more clear that those files (there are couple above of what you added) > are skipped no matter which directory they reside in. Agreed, it is

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-03 Thread Petr Jelinek
Hi, On 02/09/17 21:08, David Steele wrote: > Hackers, > > The cache in pg_internal.init was reused in days of yore but has been > rebuilt on postmaster startup since v8.1. It appears there is no reason > for this file to be backed up. > Makes sense. > I also moved the RELCACHE_INIT_FILENAME

[HACKERS] Exclude pg_internal.init from base backup

2017-09-02 Thread David Steele
Hackers, The cache in pg_internal.init was reused in days of yore but has been rebuilt on postmaster startup since v8.1. It appears there is no reason for this file to be backed up. I also moved the RELCACHE_INIT_FILENAME constant to relcache.h to avoid duplicating the string. I'll add this to