Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Fujii Masao
On Wed, Jul 1, 2015 at 8:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:18 PM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 8:16 PM, Fujii Masao wrote: I updated the patch as follows. Patch attached. +#define XLogFileNameExtended(fname, tli, log, seg) Move

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 8:18 PM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 8:16 PM, Fujii Masao wrote: I updated the patch as follows. Patch attached. +#define XLogFileNameExtended(fname, tli, log, seg) Move this macro to xlog_internal.h because it's used both in pg_standby and

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Fujii Masao
On Wed, Jun 10, 2015 at 2:41 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, While looking at the code of pg_archivecleanup.c, I noticed that there is some code present to detect if a given string has the format of a WAL segment file name or of a backup file. The recent commit

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Michael Paquier
On Thu, Jul 2, 2015 at 10:37 AM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 9:53 PM, Fujii Masao wrote: +/* Length of XLog file name */ +#define XLOG_DATA_FNAME_LEN 24 Shorten the name of this macro variable, to XLOG_FNAME_LEN, for more code readability. Thanks. You have more talent

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Fujii Masao
On Wed, Jul 1, 2015 at 9:53 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:18 PM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 8:16 PM, Fujii Masao wrote: I updated the patch as follows. Patch

[HACKERS] Expending the use of xlog_internal.h's macros

2015-06-09 Thread Michael Paquier
Hi all, While looking at the code of pg_archivecleanup.c, I noticed that there is some code present to detect if a given string has the format of a WAL segment file name or of a backup file. The recent commit 179cdd09 has introduced in xlog_internal.h a set of macros to facilitate checks of