Re: [HACKERS] FDW table hints

2011-05-05 Thread Magnus Hagander
On Thu, May 5, 2011 at 19:26, Magnus Hagander wrote: > On Thu, May 5, 2011 at 19:22, Tom Lane wrote: >> Magnus Hagander writes: >>> Since I brought it up - a patch along this line? >> >> Please don't capitalize "foreign table" there. > > Yeah, I was a bit split about that myself. Will change. >

Re: [HACKERS] FDW table hints

2011-05-05 Thread Magnus Hagander
On Thu, May 5, 2011 at 19:22, Tom Lane wrote: > Magnus Hagander writes: >> Since I brought it up - a patch along this line? > > Please don't capitalize "foreign table" there. Yeah, I was a bit split about that myself. Will change. > Also, I think an "else" before the other ereport would make t

Re: [HACKERS] FDW table hints

2011-05-05 Thread Tom Lane
Magnus Hagander writes: > Since I brought it up - a patch along this line? Please don't capitalize "foreign table" there. Also, I think an "else" before the other ereport would make the code clearer, even though it's not strictly necessary. regards, tom lane -- Sent vi

Re: [HACKERS] FDW table hints

2011-05-05 Thread Magnus Hagander
On Tue, May 3, 2011 at 16:19, Tom Lane wrote: > Dave Page writes: >> On Tue, May 3, 2011 at 10:33 AM, Susanne Ebrecht >> wrote: >>> When we make such a hint for foreign tables then we should make a similar >>> hint for views. > >> A view really isn't a table, unlike a foreign table, so I don't t

Re: [HACKERS] FDW table hints

2011-05-03 Thread Tom Lane
Dave Page writes: > On Tue, May 3, 2011 at 10:33 AM, Susanne Ebrecht > wrote: >> When we make such a hint for foreign tables then we should make a similar >> hint for views. > A view really isn't a table, unlike a foreign table, so I don't think > that argument holds. Well, from the implementat

Re: [HACKERS] FDW table hints

2011-05-03 Thread David Fetter
On Tue, May 03, 2011 at 10:42:30AM +0100, Dave Page wrote: > On Tue, May 3, 2011 at 10:33 AM, Susanne Ebrecht > wrote: > > On 03.05.2011 09:30, Magnus Hagander wrote: > >> > >> Well, yeah, but I don't think we can squeeze that into 9.1 without > >> Robert noticing :P > >> > >> Any suggestions on *

Re: [HACKERS] FDW table hints

2011-05-03 Thread Dave Page
On Tue, May 3, 2011 at 10:33 AM, Susanne Ebrecht wrote: > On 03.05.2011 09:30, Magnus Hagander wrote: >> >> Well, yeah, but I don't think we can squeeze that into 9.1 without >> Robert noticing :P >> >> Any suggestions on *what* the hint should be? Just something along the >> line "indexes cannot

Re: [HACKERS] FDW table hints

2011-05-03 Thread Susanne Ebrecht
On 03.05.2011 09:30, Magnus Hagander wrote: Well, yeah, but I don't think we can squeeze that into 9.1 without Robert noticing :P Any suggestions on *what* the hint should be? Just something along the line "indexes cannot be created on foreign tables"? Magnus, I am not really sure if this is

Re: [HACKERS] FDW table hints

2011-05-03 Thread Magnus Hagander
On Mon, May 2, 2011 at 23:56, David Fetter wrote: > On Mon, May 02, 2011 at 09:27:08PM +0200, Magnus Hagander wrote: >> postgres=# DROP TABLE FOO; >> ERROR:  "foo" is not a table >> HINT:  Use DROP FOREIGN TABLE to remove a foreign table. >> postgres=# CREATE INDEX baz ON foo(bar); >> ERROR:  "foo

Re: [HACKERS] FDW table hints

2011-05-02 Thread David Fetter
On Mon, May 02, 2011 at 09:27:08PM +0200, Magnus Hagander wrote: > postgres=# DROP TABLE FOO; > ERROR: "foo" is not a table > HINT: Use DROP FOREIGN TABLE to remove a foreign table. > postgres=# CREATE INDEX baz ON foo(bar); > ERROR: "foo" is not a table > > To some, that would be confusing - f

[HACKERS] FDW table hints

2011-05-02 Thread Magnus Hagander
postgres=# DROP TABLE FOO; ERROR: "foo" is not a table HINT: Use DROP FOREIGN TABLE to remove a foreign table. postgres=# CREATE INDEX baz ON foo(bar); ERROR: "foo" is not a table To some, that would be confusing - foo kind of is a table, just a different kind. Should we have some HINT on that