On Tue, Sep 20, 2016 at 9:25 PM, Michael Paquier
wrote:
> On Wed, Sep 21, 2016 at 12:32 AM, Robert Haas wrote:
>> For what it's worth, I think it's fine. Good error messages are a useful
>> thing.
>>
>> More generally, I think the whole patch looks good and should be committed.
>
> Hm. I'd thin
On Wed, Sep 21, 2016 at 10:25 AM, Michael Paquier
wrote:
> On Wed, Sep 21, 2016 at 12:32 AM, Robert Haas wrote:
>> For what it's worth, I think it's fine. Good error messages are a useful
>> thing.
>>
>> More generally, I think the whole patch looks good and should be committed.
>
> Hm. I'd thi
On Wed, Sep 21, 2016 at 12:32 AM, Robert Haas wrote:
> For what it's worth, I think it's fine. Good error messages are a useful
> thing.
>
> More generally, I think the whole patch looks good and should be committed.
Hm. I'd think that it is still more portable to just issue a WARNING
message i
On Mon, Jul 11, 2016 at 12:04 AM, Michael Paquier
wrote:
> On Sat, Jul 9, 2016 at 2:58 AM, Shoaib Lari wrote:
>> Besides making the error message more informative, we had to modify
>> allocate_recordbuf() to return the actual number of bytes that were being
>> allocated.
>
> - report_invali
Thank you for the feedback.
We had encountered this error message when allocating a record buf of 344
bytes. The message "record length 344 at %X/%X too long" along with the
comment /* We treat this as a "bogus data" condition */ masked the OOM
condition, implying an error in log record size cal
On 11 July 2016 at 12:04, Michael Paquier wrote:
> On Sat, Jul 9, 2016 at 2:58 AM, Shoaib Lari wrote:
> > Besides making the error message more informative, we had to modify
> > allocate_recordbuf() to return the actual number of bytes that were being
> > allocated.
>
> - report_invalid_re
On Sat, Jul 9, 2016 at 2:58 AM, Shoaib Lari wrote:
> Besides making the error message more informative, we had to modify
> allocate_recordbuf() to return the actual number of bytes that were being
> allocated.
- report_invalid_record(state, "record length %u at %X/%X too long",
-
Hello,
Attached is a patch for xlogreader.c for a more informative error message
for allocate_recordbuf() failure.
The patch details are:
- Project name.: None
- Uniquely identifiable file name, so we can tell difference between
your v1 and v24.: src/backend/access/transam/xlogread