Re: [HACKERS] Fix bloom WAL tap test

2017-11-13 Thread Alexander Korotkov
Hi! On Fri, Nov 10, 2017 at 9:12 PM, Tom Lane wrote: > I wrote: > > Is there anything we can do to cut the runtime of the TAP test to > > the point where running it by default wouldn't be so painful? > > As an experiment, I tried simply cutting the size of the test table

Re: [HACKERS] Fix bloom WAL tap test

2017-11-10 Thread Tom Lane
I wrote: > Is there anything we can do to cut the runtime of the TAP test to > the point where running it by default wouldn't be so painful? As an experiment, I tried simply cutting the size of the test table 10X: diff --git a/contrib/bloom/t/001_wal.pl b/contrib/bloom/t/001_wal.pl index

Re: [HACKERS] Fix bloom WAL tap test

2017-11-10 Thread Tom Lane
Michael Paquier writes: > On Thu, Nov 9, 2017 at 7:51 PM, Alexander Korotkov > wrote: >> OK, then so be it :) > Thanks for the new version. This one, as well as the switch to > psql_safe in >

Re: [HACKERS] Fix bloom WAL tap test

2017-11-09 Thread Michael Paquier
On Thu, Nov 9, 2017 at 7:51 PM, Alexander Korotkov wrote: > On Wed, Nov 8, 2017 at 5:46 AM, Masahiko Sawada > wrote: >> > So I think >> > that you should instead do something like that: >> > >> > --- a/contrib/bloom/Makefile >> > +++

Re: [HACKERS] Fix bloom WAL tap test

2017-11-09 Thread Alexander Korotkov
On Wed, Nov 8, 2017 at 5:46 AM, Masahiko Sawada wrote: > > So I think > > that you should instead do something like that: > > > > --- a/contrib/bloom/Makefile > > +++ b/contrib/bloom/Makefile > > @@ -20,5 +20,12 @@ include $(top_builddir)/src/Makefile.global > > include

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Masahiko Sawada
On Wed, Nov 8, 2017 at 11:20 AM, Michael Paquier wrote: > On Wed, Nov 8, 2017 at 1:58 AM, Alexander Korotkov > wrote: >> On Tue, Nov 7, 2017 at 4:34 PM, Masahiko Sawada >> wrote: >>> I understood the necessity of this

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Michael Paquier
On Wed, Nov 8, 2017 at 1:58 AM, Alexander Korotkov wrote: > On Tue, Nov 7, 2017 at 4:34 PM, Masahiko Sawada > wrote: >> I understood the necessity of this patch and reviewed two patches. > > Good, thank you. That's clearly a bug fix. >> diff

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Michael Paquier
On Wed, Nov 8, 2017 at 1:49 AM, Alexander Korotkov wrote: > On Tue, Nov 7, 2017 at 4:26 PM, Fabrízio Mello > wrote: >> The patch doesn't apply against master: >> >> fabrizio@macanudo:/d/postgresql (master) >> $ git apply

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Alexander Korotkov
Hi! On Tue, Nov 7, 2017 at 4:34 PM, Masahiko Sawada wrote: > I understood the necessity of this patch and reviewed two patches. > Good, thank you. > For /fix-bloom-wal-check.patch, it looks good to me. I found no > problem. But for wal-check-on-bloom-check.patch, if

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Alexander Korotkov
On Tue, Nov 7, 2017 at 4:26 PM, Fabrízio Mello wrote: > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation:

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Masahiko Sawada
On Fri, Sep 29, 2017 at 10:32 PM, Alexander Korotkov wrote: > On Wed, Sep 6, 2017 at 5:06 PM, Alexander Korotkov > wrote: >> >> On Wed, Sep 6, 2017 at 4:08 PM, Alexander Korotkov >> wrote: >>> >>> I just realized

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Fabrízio Mello
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested The patch doesn't apply against master: fabrizio@macanudo:/d/postgresql

Re: [HACKERS] Fix bloom WAL tap test

2017-09-29 Thread Alexander Korotkov
On Wed, Sep 6, 2017 at 5:06 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, Sep 6, 2017 at 4:08 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> I just realized that these lines of contrib/bloom/t/001_wal.pl don't >> check that queries give same results on

Re: [HACKERS] Fix bloom WAL tap test

2017-09-06 Thread Alexander Korotkov
On Wed, Sep 6, 2017 at 4:08 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > I just realized that these lines of contrib/bloom/t/001_wal.pl don't > check that queries give same results on master and standby. They just > check that *return codes* of psql are equal. > > # Run test

[HACKERS] Fix bloom WAL tap test

2017-09-06 Thread Alexander Korotkov
Hi! I just realized that these lines of contrib/bloom/t/001_wal.pl don't check that queries give same results on master and standby. They just check that *return codes* of psql are equal. # Run test queries and compare their result > my $master_result = $node_master->psql("postgres", $queries);