Re: [HACKERS] Fix comment in ATExecValidateConstraint

2016-09-15 Thread Robert Haas
On Thu, Aug 18, 2016 at 9:01 PM, Amit Langote wrote: > Reads much less ambiguous, so +1. > > Except in the doc patch: > > s/change the type of a column constraint/change the type of a column/g > > I fixed that part in the attached. Thanks. Committed; sorry for the delay. (As some of those of yo

Re: [HACKERS] Fix comment in ATExecValidateConstraint

2016-08-18 Thread Amit Langote
On 2016/08/19 5:35, Robert Haas wrote: > On Thu, Aug 18, 2016 at 5:15 AM, Amit Langote > wrote: >> On 2016/07/25 17:18, Amit Langote wrote: >>> The comment seems to have been copied from ATExecAddColumn, which says: >>> >>> /* >>> * If we are told not to recurse, there had better not be any >>>

Re: [HACKERS] Fix comment in ATExecValidateConstraint

2016-08-18 Thread Robert Haas
On Thu, Aug 18, 2016 at 5:15 AM, Amit Langote wrote: > On 2016/07/25 17:18, Amit Langote wrote: >> The comment seems to have been copied from ATExecAddColumn, which says: >> >> /* >> * If we are told not to recurse, there had better not be any >> - * child tables; else the addition would put th

Re: [HACKERS] Fix comment in ATExecValidateConstraint

2016-08-18 Thread Amit Langote
On 2016/07/25 17:18, Amit Langote wrote: > The comment seems to have been copied from ATExecAddColumn, which says: > > /* > * If we are told not to recurse, there had better not be any > - * child tables; else the addition would put them out of step. > > For ATExecValidateConstraint, it should

Re: [HACKERS] Fix comment in ATExecValidateConstraint

2016-08-15 Thread Amit Langote
On 2016/07/29 23:50, Robert Haas wrote: > On Mon, Jul 25, 2016 at 4:18 AM, Amit Langote > wrote: >> The comment seems to have been copied from ATExecAddColumn, which says: >> >> /* >> * If we are told not to recurse, there had better not be any >> - * child tables; else the addition would put t

Re: [HACKERS] Fix comment in ATExecValidateConstraint

2016-07-29 Thread Robert Haas
On Mon, Jul 25, 2016 at 4:18 AM, Amit Langote wrote: > The comment seems to have been copied from ATExecAddColumn, which says: > > /* > * If we are told not to recurse, there had better not be any > - * child tables; else the addition would put them out of step. > > For ATExecValidateConstraint

[HACKERS] Fix comment in ATExecValidateConstraint

2016-07-25 Thread Amit Langote
The comment seems to have been copied from ATExecAddColumn, which says: /* * If we are told not to recurse, there had better not be any - * child tables; else the addition would put them out of step. For ATExecValidateConstraint, it should say something like: + * child tables; else validating