Re: [HACKERS] Fixup some misusage of appendStringInfo and friends

2017-08-15 Thread David Rowley
On 16 August 2017 at 15:38, Peter Eisentraut wrote: > committed Thanks! -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Fixup some misusage of appendStringInfo and friends

2017-08-15 Thread Peter Eisentraut
On 4/26/17 20:14, David Rowley wrote: > On 27 April 2017 at 06:41, Peter Eisentraut > wrote: >> On 4/19/17 08:42, Ashutosh Bapat wrote: >>> I reviewed the patch. It compiles clean, make check-world passes. I do >>> not see any issue with it. >> >> Looks

Re: [HACKERS] Fixup some misusage of appendStringInfo and friends

2017-07-13 Thread Heikki Linnakangas
On 04/27/2017 03:14 AM, David Rowley wrote: On 27 April 2017 at 06:41, Peter Eisentraut wrote: On 4/19/17 08:42, Ashutosh Bapat wrote: I reviewed the patch. It compiles clean, make check-world passes. I do not see any issue with it. Looks reasonable. Let's

Re: [HACKERS] Fixup some misusage of appendStringInfo and friends

2017-04-26 Thread David Rowley
On 27 April 2017 at 06:41, Peter Eisentraut wrote: > On 4/19/17 08:42, Ashutosh Bapat wrote: >> I reviewed the patch. It compiles clean, make check-world passes. I do >> not see any issue with it. > > Looks reasonable. Let's keep it for the next commit fest.

Re: [HACKERS] Fixup some misusage of appendStringInfo and friends

2017-04-26 Thread Peter Eisentraut
On 4/19/17 08:42, Ashutosh Bapat wrote: > I reviewed the patch. It compiles clean, make check-world passes. I do > not see any issue with it. Looks reasonable. Let's keep it for the next commit fest. > > On Wed, Apr 19, 2017 at 9:13 AM, David Rowley > wrote: >>

Re: [HACKERS] Fixup some misusage of appendStringInfo and friends

2017-04-19 Thread Ashutosh Bapat
I reviewed the patch. It compiles clean, make check-world passes. I do not see any issue with it. On Wed, Apr 19, 2017 at 9:13 AM, David Rowley wrote: > The attached cleans up a few small misusages of appendStringInfo and > related functions. > > Some similar work

[HACKERS] Fixup some misusage of appendStringInfo and friends

2017-04-18 Thread David Rowley
The attached cleans up a few small misusages of appendStringInfo and related functions. Some similar work was done in, f92d6a540ac443f85f0929b284edff67da14687a d02f16470f117db3038dbfd87662d5f0eb5a2a9b cacbdd78106526d7c4f11f90b538f96ba8696fb0 so the majority of these should all be new