Re: [PATCHES] [HACKERS] Function structure in formatting.c

2007-08-13 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Brendan Jurd wrote: > Hello, > > As discussed on -hackers, I've done some refactoring work on > backend/utils/adt/fo

Re: [HACKERS] Function structure in formatting.c

2007-08-09 Thread Brendan Jurd
On 8/9/07, Jaime Casanova <[EMAIL PROTECTED]> wrote: > > take your time, this seems like it will be for 8.4 anyway > I hear you, unfortunately "taking my time" usually means I forget about it for eight months and by the time I come back to it I've forgotten what I was doing =) I wasn't really exp

Re: [HACKERS] Function structure in formatting.c

2007-08-08 Thread Jaime Casanova
On 8/9/07, Brendan Jurd <[EMAIL PROTECTED]> wrote: > Just quick update on this. It turns out (as it always does) that I > want to refactor a bit more intensively than I first suggested. > [...] > This means there is no need to put pointers to "action functions" in > each of the KeyWords. It makes

Re: [HACKERS] Function structure in formatting.c

2007-08-08 Thread Brendan Jurd
Just quick update on this. It turns out (as it always does) that I want to refactor a bit more intensively than I first suggested. The functions dch_global, dch_time and dch_date seem to be wholly pointless, since dch_global is effectively a one-liner for the FX flag, and the other two merely wra

Re: [HACKERS] Function structure in formatting.c

2007-08-08 Thread Brendan Jurd
On 8/9/07, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: > > To my mind, it would make a lot more sense (and make hacking the file > > a lot easier) if the processing functions were split into to_char and > > from_char variants. I'm not sure what, if any, advanta

Re: [HACKERS] Function structure in formatting.c

2007-08-08 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > To my mind, it would make a lot more sense (and make hacking the file > a lot easier) if the processing functions were split into to_char and > from_char variants. I'm not sure what, if any, advantage is gleaned > by having these functions combined. Ye

[HACKERS] Function structure in formatting.c

2007-08-08 Thread Brendan Jurd
Hi hackers, I'm currently poking around in backend/utils/adt/formatting.c with a view to improving to_date() parsing (see thread at http://archives.postgresql.org/pgsql-hackers/2007-07/msg00513.php), and I've noticed that the way the functions are organised is pretty weird. The original author a