Re: [HACKERS] HINT message for "ALTER SUBSCRIPTION.. WITH" need to change with SET keyword

2017-05-19 Thread Peter Eisentraut
On 5/19/17 06:58, Dilip Kumar wrote:
> On Fri, May 19, 2017 at 3:41 PM, tushar  wrote:
>> postgres=# drop subscription sub;
>> ERROR:  could not connect to publisher when attempting to drop the
>> replication slot "pub"
>> DETAIL:  The error was: could not connect to server: No such file or
>> directory
>> Is the server running locally and accepting
>> connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
>> HINT:  Use ALTER SUBSCRIPTION ... WITH (slot_name = NONE) to disassociate
>> the subscription from the slot.
>>
>> expected = "HINT:  Use ALTER SUBSCRIPTION ... SET (slot_name = NONE) to
>> disassociate the subscription from the slot."
> 
> Seems like syntax got changed in
> b807f59828fbc02fea612e1cbc0066c6dfa3be9b commit but missed to change
> the hint. Attached patch fixes that.

Fixed, thanks.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] HINT message for "ALTER SUBSCRIPTION.. WITH" need to change with SET keyword

2017-05-19 Thread Dilip Kumar
On Fri, May 19, 2017 at 3:41 PM, tushar  wrote:
> postgres=# drop subscription sub;
> ERROR:  could not connect to publisher when attempting to drop the
> replication slot "pub"
> DETAIL:  The error was: could not connect to server: No such file or
> directory
> Is the server running locally and accepting
> connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
> HINT:  Use ALTER SUBSCRIPTION ... WITH (slot_name = NONE) to disassociate
> the subscription from the slot.
>
> expected = "HINT:  Use ALTER SUBSCRIPTION ... SET (slot_name = NONE) to
> disassociate the subscription from the slot."

Seems like syntax got changed in
b807f59828fbc02fea612e1cbc0066c6dfa3be9b commit but missed to change
the hint. Attached patch fixes that.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com


fix_subscription_hint.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] HINT message for "ALTER SUBSCRIPTION.. WITH" need to change with SET keyword

2017-05-19 Thread tushar

Hi,

There is small issue in the HINT message which we provide at the time of 
dropping subscription ,where we are saying -WITH (slot_name) which need 
to change with SET (slot_name).


postgres=# drop subscription sub;
ERROR:  could not connect to publisher when attempting to drop the 
replication slot "pub"
DETAIL:  The error was: could not connect to server: No such file or 
directory

Is the server running locally and accepting
connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
HINT:  Use ALTER SUBSCRIPTION ... *WITH* (slot_name = NONE) to 
disassociate the subscription from the slot.


expected = "HINT:  Use ALTER SUBSCRIPTION ... *SET* (slot_name = NONE) 
to disassociate the subscription from the slot."


--
regards,tushar
EnterpriseDB  https://www.enterprisedb.com/
The Enterprise PostgreSQL Company